Assistance with exiting a trade at a specific time

October 22nd, 2022, 12:47 PM

Evening.

In the below code my strategy enters trades within the given window of time while my exit code is not. I'd like my trades to exit at 2pm yet when I Optimize/Backtest a strategy the code will exit at 9am / 9:05am / 10am / 12:01pm / 5pm / 5:31pm....pretty much everything BUT 2pm. Can someone please point out what i'm doing incorrect?

namespace NinjaTrader.NinjaScript.Strategies
{
public class Test : Strategy
{

protected override void OnStateChange()
{
if (State == State.SetDefaults)
{
Name = "Test ";
Calculate = Calculate.OnBarClose;
EntriesPerDirection = 1;
EntryHandling = EntryHandling.AllEntries;
IsExitOnSessionCloseStrategy = false;
IsFillLimitOnTouch = false;
MaximumBarsLookBack = MaximumBarsLookBack.Infinite;
OrderFillResolution = OrderFillResolution.Standard;
Slippage = 2;
StartBehavior = StartBehavior.WaitUntilFlat;
TimeInForce = TimeInForce.Gtc;
TraceOrders = false;
RealtimeErrorHandling = RealtimeErrorHandling.StopCancelClose;
StopTargetHandling = StopTargetHandling.PerEntryExecution;
BarsRequiredToTrade = 1;
// Disable this property for performance gains in Strategy Analyzer optimizations
// See the Help Guide for additional information
IsInstantiatedOnEachOptimizationIteration = true;

Start_Time = DateTime.Parse("07:00", System.Globalization.CultureInfo.InvariantCulture) ;
End_Time = DateTime.Parse("12:00", System.Globalization.CultureInfo.InvariantCulture) ;
Exit_Trades = DateTime.Parse("14:00", System.Globalization.CultureInfo.InvariantCulture) ;

TradeLong = false;
TradeShort = false;

}

else if (State == State.Configure)
{
}
else if (State == State.DataLoaded)
{
}

}

protected override void OnBarUpdate()
{

if (
(Time[0].TimeOfDay >= Start_Time.TimeOfDay)
&& (Time[0].TimeOfDay <= End_Time.TimeOfDay)
)

{

// Look for Long Entries
if ( TradeLong )
{
EnterLong(Contract_Qty,@"L");
}

// Look for Short Entries
if ( TradeShort )
{
EnterShort(Contract_Qty,@"S");
}
}

//Exit Trades at specific time
if (
Time[0].TimeOfDay >= Exit_Trades.TimeOfDay
)
{
if (
Position.MarketPosition == MarketPosition.Long
)
{
ExitLong(1, "eLong", "L");
}

if (
Position.MarketPosition == MarketPosition.Short
)
{
ExitShort(1, "eShort", "S");
}
}

}

October 22nd, 2022, 09:49 PM

I don't really know about ninjatrader programming, just throwing out ideas here before competent help arrives.

If entering during the correct time, then maybe the problem is with the market position part. Do you have to specify the market position? Thinking maybe can test by doing something like

if (
Time[0].TimeOfDay >= Exit_Trades.TimeOfDay
)
{
ExitLong(1, "eLong", "L");
}

See if it exits your long positions. If not, then probably the time part.

Or maybe because you are specifying 1 in the exit, and not "Contract_Qty" and that's not matching up somehow? Can you just do ExitLong()?

Or maybe

Time[0].TimeOfDay >= Exit_Trades.TimeOfDay should be

Time[0].TimeOfDay >= Exit_Trades.TimeOfDay && Time[1].TimeOfDay < Exit_Trades.TimeOfDay

Probably not the last one.

October 23rd, 2022, 10:35 AM

Thank you RandomDude. Kinda exactly what I needed to do. Take a step back and isolate where the issue was stemming from.

In my case, not sure why, I discovered (or it appears) that I need to code my Exits as followed: Add a bool for the TradeLong & TradeShort

//Exit Trades at specific time

if ( TradeLong )
{

if (
Time[0].TimeOfDay >= Exit_Trades.TimeOfDay
)
{
if (
Position.MarketPosition == MarketPosition.Long
)
{
ExitLong(Contract_Qty, "eLong", "L");
}

}

}

if ( TradeShort )
{

if (
Time[0].TimeOfDay >= Exit_Trades.TimeOfDay
)
{
if (
Position.MarketPosition == MarketPosition.Short
)
{
ExitShort(Contract_Qty, "eShort", "S");
}
}

}

Assistance with exiting a trade at a specific time

Discussion in NinjaTrader

Assistance with exiting a trade at a specific time