Drawing dots based on a condition

June 2nd, 2016, 07:27 PM

Hi,

I am new to coding in NinjaTrader. I have done some coding in EasyLanguage, AmiBroker and Python, but I'm just a trial and error guy, not a 'proper' coder.

As a first foray into Ninja, I am trying to draw a dot beneath bars based on a condition being true.

if I make my condition as simple as possible, like this:

Code

if (Close[0] < Open[0])

-- the dots display correctly.

But, if I try to refer to previous bars, like this:

Code

if (Close[0] < Open[1])

-- the code does not work. So, I assume it is the condition itself which I am getting wrong.

Can anybody explain why this change would stop the code working, and how I would correctly refer to previous bars?

Any help appreciated.

Here's the rest of the code.

Code

protected override void OnBarUpdate()
        {

			{	
				
				if (Close[0] < Open[0]) 
				//if (Close[1] > Open[1])
				//if(Close[1] < Close[0] && Close[1] < Close[2])
					
					{ 
						myBarCloses=1;
					} else {
						myBarCloses=0;
					}
					
					if (myBarCloses==1) 
					{
						DrawDot(CurrentBar.ToString() +"BarCloseDot",true, 0, Low[0]*0.997, Color.Magenta);
					}
					
			}      
			
        }

June 5th, 2016, 12:13 AM

In case anybody else has a need for this information, it requires a check for enough bars in the data series you are accessing.

I don't know whether posting external links is permitted, so I'll assume it is not. A Google search should find the info.

I had to amend the code as below.

Code

protected override void OnBarUpdate()
{
    if (CurrentBar < 1)
        return;

    if (Close[0] < Open[1])
        // etc
}

June 7th, 2016, 06:30 PM

What do you mean "it does not work"? What exactly do you do and then what happens?
Is this for a strategy or an indicator?
Have you checked the "Log" tab in the "Control Center" for any runtime error messages? If so what do they say?

Drawing dots based on a condition

Discussion in NinjaTrader

Drawing dots based on a condition