Can someone tell me why this happens

July 10th, 2015, 06:00 AM

Can anyone tell me why this code only opens long positions and doesn't open on the next bar after a signal. It also open a trade as soon as i start the EA regardless of when the signal was i.e x bars ago

Thank you

Code

                            
//+------------------------------------------------------------------+
//|                                                  A Daytrader.mq4 |
//|                                                               RG |
//|                                                                  |
//+------------------------------------------------------------------+

//---- input parameters

extern double    TakeProfit=70.0;
extern double    Lots=3;
extern double    TrailingStop=15.0;
//+------------------------------------------------------------------+
//| expert initialization function                                   |
//+------------------------------------------------------------------+
int init()
  {
//---- 
   
//----
   return(0);
  }
//+------------------------------------------------------------------+
//| expert deinitialization function                                 |
//+------------------------------------------------------------------+
int deinit()
  {
//---- 
   
//----
   return(0);
  }


//+------------------------------------------------------------------+
//| expert start function                                            |
//+------------------------------------------------------------------+
int start()
  {
//---- 

   
   int cnt, ticket, total;
   double ArrowUp, ArrowDown;
   
   
   
   if(Bars<100)
     {
      Print("bars less than 100");
      return(0);  
     }
   if(TakeProfit<10)
     {
      Print("TakeProfit less than 10");
      return(0);  // check TakeProfit
     }
     
     
      ArrowUp = iCustom(NULL,0,"PZ_DayTrading",0,1);
      ArrowDown = iCustom(NULL,0,"PZ_DayTrading",1,1);
   
   
   
   total  = OrdersTotal(); 
   if(total < 1) 
     
     {
       if  (ArrowUp!=1)
         {
            ticket=OrderSend(Symbol(),OP_BUY,Lots,Ask,3,0,Ask+TakeProfit*Point,"DayTrader",12345,0,Green);
            if(ticket>0)
              {
               if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("BUY order opened : ",OrderOpenPrice());
              }
            
            return(0);
         }
         else if (ArrowDown!=2)
         {

            ticket=OrderSend(Symbol(),OP_SELL,Lots,Bid,3,0,Bid-TakeProfit*Point,"DayTrader",12345,0,Red);
            if(ticket>0)
              {
               if(OrderSelect(ticket,SELECT_BY_TICKET,MODE_TRADES)) Print("SELL order opened : ",OrderOpenPrice());
              }
            
            return(0);
         }
         return(0);
     }
   for(cnt=0;cnt<total;cnt++)
     
   return(0);
  }
//+-----------------------------------------------------------

July 10th, 2015, 06:54 AM

Only problem is what you are asking for in debugging this code can quickly turn into a very time consuming effort. Did you write it?

July 10th, 2015, 06:58 AM

Hi, thanks for the reply.

I have pulled bits of code from other EAs as I am trying to write my own, and failing. Any assistance on how to correct the issue would be greatly appreciated.

July 10th, 2015, 07:02 AM

I assumed it was C# Ninja code because your info says you use Ninja as your platform. But I now see this thread is in the Metatrader sub-forum.
I only do Ninja stuff and very badly at that.....lol
Maybe if you post the file someone might have a better chance of helping out and maybe if you can have a more concrete question narrowed down to a piece of code within the whole....????

July 10th, 2015, 12:03 PM

https://www.mql5.com/en/charts/3681899/eurusd-m15-fxprimus-ltd

Here you can see a long position open a few bars after the short signal, should have been a short trade. Still no buy orders. No idea whats happening , can anyone help.

Have a missed something in the code relating to my order management.

August 3rd, 2015, 02:38 PM

Hi, can you elaborate it as I the the informative provided by you is insufficient.

Can someone tell me why this happens

Discussion in Platforms and Indicators

Can someone tell me why this happens