Little coding help needed

April 10th, 2014, 08:02 AM

I´m trying to define the bar open and close as precondition in an code snippet.
If the bar open and close is located in the upper/lower third of the bar range, than do something.

if(Open[0] && Close[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]>VOL()[1]))

The "if(Open[0] && Close[0]" is the part that didn´t work. I´ve searched the NT help guide and www, but couldn´t find anything helpful.

Has anyone an idea how I can set the open and close as a precondition?

April 10th, 2014, 08:14 AM

Abde

I´m trying to define the bar open and close as precondition in an code snippet.
If the bar open and close is located in the upper/lower third of the bar range, than do something.

if(Open[0] && Close[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]>VOL()[1]))

The "if(Open[0] && Close[0]" is the part that didn´t work. I´ve searched the NT help guide and www, but couldn´t find anything helpful.

Has anyone an idea how I can set the open and close as a precondition?

- open and close located in the upper third
- meaning: reversal bar up with a lower shadow that exceeds 2/3 of the bar range

Code

if( Math.Min (Open[0], Close[0])  >   (2*High[0] + Low[0])/3.0)

- open and close located in the lower third
- meaning: reversal bar down with an upper shadow that exceeds 2/3 of the bar range

Code

if( Math.Max (Open[0], Close[0])  <   (High[0] + 2*Low[0])/3.0)

April 10th, 2014, 08:21 AM

Abde

I´m trying to define the bar open and close as precondition in an code snippet.
If the bar open and close is located in the upper/lower third of the bar range, than do something.

if(Open[0] && Close[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]>VOL()[1]))

The "if(Open[0] && Close[0]" is the part that didn´t work. I´ve searched the NT help guide and www, but couldn´t find anything helpful.

Has anyone an idea how I can set the open and close as a precondition?

Hi Adbe,

Just for clarity, the if statement is looking for a logical true/false in which to move. Each side of && has to resolve to True or false To work. The statement part Open[0] doesn't have any T/F evaluation as written. , here is what it would need to look like:

if((Open[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]>VOL()[1]))) && (Close[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]>VOL()[1])))

@FatTails of course offers a superior method.

April 10th, 2014, 08:44 AM

Abde

I´m trying to define the bar open and close as precondition in an code snippet.
If the bar open and close is located in the upper/lower third of the bar range, than do something.

if(Open[0] && Close[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]>VOL()[1]))

The "if(Open[0] && Close[0]" is the part that didn´t work. I´ve searched the NT help guide and www, but couldn´t find anything helpful.

Has anyone an idea how I can set the open and close as a precondition?

@Abde,

here's an indicator that does something similar

edit: this is an old indicator I found here. don't know who made it. but I definitely would use @Fat Tails logic

April 10th, 2014, 09:20 AM

Fat Tails

- open and close located in the upper third
- meaning: reversal bar up with a lower shadow that exceeds 2/3 of the bar range

Code

if( Math.Min (Open[0], Close[0])  >   (2*High[0] + Low[0])/3.0)

- open and close located in the lower third
- meaning: reversal bar down with an upper shadow that exceeds 2/3 of the bar range

Code

if( Math.Max (Open[0], Close[0])  <   (High[0] + 2*Low[0])/3.0)

A big thank you @Fat Tails for the kind help!

It works perfect and is by the way, a very elegant solution.

April 10th, 2014, 09:57 AM

Tasker_182

Hi Adbe,

Just for clarity, the if statement is looking for a logical true/false in which to move. Each side of && has to resolve to True or false To work. The statement part Open[0] doesn't have any T/F evaluation as written. , here is what it would need to look like:

if((Open[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]>VOL()[1]))) && (Close[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]>VOL()[1])))

@FatTails of course offers a superior method.

Hi @Tasker_182,

Thanks for tying to help. Have tested your provided code, but unfortunately it didn´t work (Compile).

Maybe I did something wrong, here is the code how I used it:

Code

                            
if((Open[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]<VOL()[1]))) && (Close[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]<VOL()[1])));

April 10th, 2014, 10:01 AM

Abde

Hi @Tasker_182,

Thanks for tying to help. Have tested your provided code, but unfortunately it didn´t work (Compile).

Maybe I did something wrong, here is the code how I used it:

Code

                            
if((Open[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]<VOL()[1]))) && (Close[0] >= (High[0] + Low[0])/1.5 && (VOL()[0]<VOL()[1])));

Hi Abde,

I wasn't trying to write your correct code, i was trying to help you understand that having Open[0] by itself was not a condition of true of false and that the correct way to write the condition based on your code was what i was showing. Sorry I should have been more clear.

April 10th, 2014, 11:36 AM

Silvester17

@Abde,

here's an indicator that does something similar

edit: this is an old indicator I found here. don't know who made it. but I definitely would use @Fat Tails logic

Thanks @Silvester17 for posting the ReversalBars, which I didn´t had before.

It´s a interesting one because of the selectable wick percent feature. But of course, I will use Fat Tails code for my purpose.

April 10th, 2014, 11:45 AM

Tasker_182

Hi Abde,

I wasn't trying to write your correct code, i was trying to help you understand that having Open[0] by itself was not a condition of true of false and that the correct way to write the condition based on your code was what i was showing. Sorry I should have been more clear.

@Tasker_182,

Ok have understood. Will have a closer look to study it and try to make it work for learning purposes.

Little coding help needed

Discussion in NinjaTrader

Little coding help needed