Colour Bar Script Assistance

March 16th, 2011, 11:18 PM

I am trying to learn this stuff !
Hoping someone can help.

This is what I have.
I've tried every combination of curly brakets and even those that compile keep
ALL bars coloured Magenta.

protected override void OnBarUpdate()

{
Value.Set(100 * (MAX(High, Period)[0] - Close[0]) / (MAX(High, Period)[0] - MIN(Low, Period)[0] == 0 ? 1 : MAX(High, Period)[0] - MIN(Low, Period)[0]));

if (Value[0] > 0);

BarColor = Color.Blue;

if (Value[0] < 0);

BarColor = Color.Magenta;

}

thx

March 17th, 2011, 12:53 AM

One useful thing is troubleshooting. Add a print() statement or two so you can see the value, and probably find the error in the calculation.

It's been a while, but something like:

Code

                            
Print(CurrentBar[0] + ": " + Value[0]);

Mike

March 17th, 2011, 04:16 AM

zt379

I am trying to learn this stuff !
Hoping someone can help.

This is what I have.
I've tried every combination of curly brakets and even those that compile keep
ALL bars coloured Magenta.

protected override void OnBarUpdate()

{
Value.Set(100 * (MAX(High, Period)[0] - Close[0]) / (MAX(High, Period)[0] - MIN(Low, Period)[0] == 0 ? 1 : MAX(High, Period)[0] - MIN(Low, Period)[0]));

if (Value[0] > 0);

BarColor = Color.Blue;

if (Value[0] < 0);

BarColor = Color.Magenta;

}

thx

try this one:

if (Value[0] > 0);

{
BarColor = Color.Blue;
}
else
{
BarColor = Color.Magenta;
}

March 17th, 2011, 04:52 AM

zt379

if (Value[0] > 0);

BarColor = Color.Blue;

if (Value[0] < 0);

BarColor = Color.Magenta;

redratsal

try this one:

if (Value[0] > 0);

{
BarColor = Color.Blue;
}
else
{
BarColor = Color.Magenta;
}

remove the ;

March 17th, 2011, 12:55 PM

bukkan

remove the ;

And the winner is................
bukkan.
I only wish I understood why ! lol

I've changed it to a CrossAbove and CrossBelow statement:
I've coloured the bars ok for CrossAbove +5 and CrossBelow -5,
without the "else" statement.(which should colour all bars between +5 and -5 as gray)

But when I add the else statement I get the magenta bars ok but all other bars are gray:

I used :

if (CrossAbove (+5,Value,1))
{
BarColor = Color.Blue;
}
if (CrossBelow (-5,Value,1))
{
BarColor = Color.Magenta;
}
else
{
BarColor = Color.Gray;
}
}

Many thx

March 17th, 2011, 07:09 PM

if (CrossAbove (+5,Value,1))
BarColor = Color.Blue;
else
if (CrossBelow (-5,Value,1))
BarColor = Color.Magenta;
else
BarColor = Color.Gray;

Not sure if the logic here is good, if a CrossBelow can possibly happen while in the CrossAbove condition but this is the way to test anyway.

March 17th, 2011, 07:42 PM

eDanny

if (CrossAbove (+5,Value,1))
BarColor = Color.Blue;
else
if (CrossBelow (-5,Value,1))
BarColor = Color.Magenta;
else
BarColor = Color.Gray;

Not sure if the logic here is good, if a CrossBelow can possibly happen while in the CrossAbove condition but this is the way to test anyway.

eDanny

It's working as per your post, all be it with 2 x } at the end so many thanks.

I'm at a loss as to the reasons for differences in how to group things within the curly brackets, or
as and when they are needed.
I spend hours only to find out my mistake is down to one single bracket or a semi colon etc..

Any suggestion as to what material/video/link (anything) that would help me learn this stuff
would be great, if you have time.

Again my thanks

March 17th, 2011, 07:51 PM

If you have two statements after an if() test you will need to enclose them ind curly brackets or else only the first one will execute according to the result of the test.

if (CrossAbove (+5,Value,1))
BarColor = Color.Blue;
Print("We changed the bar color!");

Above code will only change the bar color if the CrossAbove test is passed but it will always execute the Print statement. To only Print when the bar color changes you would uses brackets to group them together.

if (CrossAbove (+5,Value,1))
{
BarColor = Color.Blue;
Print("We changed the bar color!");
}

March 17th, 2011, 08:15 PM

eDanny

If you have two statements after an if() test you will need to enclose them ind curly brackets or else only the first one will execute according to the result of the test.

if (CrossAbove (+5,Value,1))
BarColor = Color.Blue;
Print("We changed the bar color!");

Above code will only change the bar color if the CrossAbove test is passed but it will always execute the Print statement. To only Print when the bar color changes you would uses brackets to group them together.

if (CrossAbove (+5,Value,1))
{
BarColor = Color.Blue;
Print("We changed the bar color!");
}

So by having "else if" after the first "if", we don't need any brackets, hence your script in your post#7 works ?

But I'm confused.
I did have statements bracketed , see my post#6,
yet the first Color.Blue did not print, only the Magenta and Gray printed.

Perhaps I'm not understanding what your saying ?

thx

Colour Bar Script Assistance

Discussion in NinjaTrader

Colour Bar Script Assistance