can you help with code, would like to paint low volume bar black

December 18th, 2010, 06:49 AM

why is this not working??
would like to paint volume bar black if it is below a certain amount
protected override void Initialize()
{
Add(new Plot(new Pen(Color.Lime, 2), PlotStyle.Bar, "UpVolume"));
Add(new Plot(new Pen(Color.Red, 2), PlotStyle.Bar, "DownVolume"));
Add(new Plot(new Pen(Color.Black, 2), PlotStyle.Bar, "LowVol"));
Add(new Line(Color.DarkGray, 0, "Zero line"));
DrawOnPricePanel = false;
}

/// <summary>
/// Called on each bar update event (incoming tick)
/// </summary>
protected override void OnBarUpdate()
{
if (Close[0] >= Open[0])
{
Values[0].Set(Volume[0]);
Values[1].Reset();

if (Volume[1]<x)
{ Values[2].Set(Volume[1]);
}
}
else
{
Values[1].Set(Volume[0]);
Values[0].Reset();
if (Volume[1]<x)
{ Values[2].Set(Volume[1]);

many thanks for your help/advise

December 18th, 2010, 09:24 AM

Here are some changes that I suggest. Have not tested them. Also ou need to declare the Variable x via "double x = 0.0;" somewhere.

Code

 
protected override void Initialize()
{
Add(new Plot(new Pen(Color.Lime, 2), PlotStyle.Bar, "UpVolume"));
Add(new Plot(new Pen(Color.Red, 2), PlotStyle.Bar, "DownVolume"));
Add(new Plot(new Pen(Color.Black, 2), PlotStyle.Bar, "LowVol"));
Add(new Line(Color.DarkGray, 0, "Zero line"));
Overlay = false;  // DrawOnPricePanel is needed for additional drawing features, you probably mean "Overlay = false;"
}
 
/// <summary>
/// Called on each bar update event (incoming tick)
/// </summary>
protected override void OnBarUpdate()
{
if (Close[0] >= Open[0])
{
Values[0].Set(Volume[0]);
Values[1].Set(0.0);
} 
else // continue here for negative volume
{
Values[1].Set(Volume[0]);
Values[0].Set(0.0);
} 
// good idea to repaint the last bar after it became a low volume bar, but the first bar on the chart (index 0)does not have a last bar, so you may only start this with the second bar (index 1) -> CurrentBar > 0 is required
if (CurrentBar > 0 && Volume[1] < x)
{ 
Values[0].Set(1,0.0);
Values[1].Set(1,0.0);
Values[2].Set(1, Volume[1]); // you do not want to set the value for the current volume bar but for the prior bar
so you need to use the correct syntax Set( int barsAgo, double value)
}
Values[2].Set(0.0); // always, only affects the current incomplete bar
}

Further suggestions:

If you post code, you can use [Code] tags -> just highlight the code and select # on your task bar

The condition

Code

 
if (CurrentBar > 0 && Volume[1] < x)

will work but is annoying, because you have to change the value of x for every instrument. You could try

Code

 
if(CurrentBar > 10 && Volume[1] == MIN(Volume, 10)[1])

This would show the bar as a low volume bar, if it has the lowest volume of the last 20 bars - not including the current active bar, which is yet incomplete.

December 19th, 2010, 01:55 AM

thank you soooo much fat tails -

i get the gist of yr code and will play around with it

December 19th, 2010, 03:58 AM

yep, code is correct - just needed to declare variable as you said

can you help with code, would like to paint low volume bar black

Discussion in NinjaTrader

can you help with code, would like to paint low volume bar black