A little programming help plz

August 28th, 2010, 09:39 AM

Maybe I should have the settings under Initialize() like in the original vwap indicator?

protected override void Initialize()
{
Add(new Plot(Color.Orange, "VWAP"));
Add(new Plot(Color.Blue, "SD1 Upper"));
Add(new Plot(Color.Blue, "SD1 Lower"));
Add(new Plot(Color.Blue, "SD2 Upper"));
Add(new Plot(Color.Blue, "SD2 Lower"));
Add(new Plot(Color.Blue, "SD3 Upper"));
Add(new Plot(Color.Blue, "SD3 Lower"));

vwapsd = new DataSeries(this);
AutoScale = false;
BarsRequired = 1;
CalculateOnBarClose = false;
Overlay = true;
PriceTypeSupported = true;
}

August 28th, 2010, 09:39 AM

mpe66

I'm using the indicator from post 258 in this thread on the NT forum. I'm pretty sure the name of the plot is just VWAP or at least that's what it's called in the indicator settings...

Names of the plots are not the ones in the indicator's settings but in the properties region of the vwap.cs file

August 28th, 2010, 09:42 AM

As for properties: use the wizard and ask for one of the VWAP plots, then generate the code and you will see what parameters were included

You could actually have your indicator done using wizard only

August 28th, 2010, 09:45 AM

gregid

As for properties: use the wizard and ask for one of the VWAP plots, then generate the code and you will see what parameters were included

You could actually have your indicator done using wizard only

Thanks, I'll try that.

August 28th, 2010, 10:14 AM

gregid

As for properties: use the wizard and ask for one of the VWAP plots

How do I do that? Been going through the help guides but can't get this to work.

August 28th, 2010, 11:04 AM

Use the attached indicator. You can call it from your code as follows:

TimeSpan endtime = new TimeSpan(0,0,0);
TimeSpan starttime = new TimeSpan(0,0,0);
double a = VWAP(1,endtime,1,1,1,1,true,true,starttime)[0];

August 28th, 2010, 11:06 AM

what exactly you can't do?

August 28th, 2010, 11:49 AM

MooreTech

Use the attached indicator. You can call it from your code as follows:

TimeSpan endtime = new TimeSpan(0,0,0);
TimeSpan starttime = new TimeSpan(0,0,0);
double a = VWAP(1,endtime,1,1,1,1,true,true,starttime)[0];

Thanks for all your help. I don't really know what I'm doing but I tried pasting the 3 lines into my script in onbarupdate(?) and parameters into VWAP() and got it to compile without errors. However, it doesn't plot anything on my chart. Should it be VWAP().VWAPLine or just VWAP().VWAP for this VWAP indicator? I'll attach my indicator...

Mpe

August 28th, 2010, 03:13 PM

Your indicator should look like this

Code

                            

            TimeSpan endtime = new TimeSpan(0,0,0);
            TimeSpan starttime = new TimeSpan(0,0,0);
            double vwap = VWAP(1,endtime,3,1,2,3,true,true,starttime).VWAPLine[0];
            double sdupper = VWAP(1,endtime,3,1,2,3,true,true,starttime).SD1Upper[0];
            double denom = sdupper-vwap;
            
            if (denom!=0)
                Value.Set ((Close[0] - vwap) / (sdupper - vwap));
            else
                Value.Set(0);

August 28th, 2010, 03:52 PM

This works, however I was not able to pass the starttime and endtime parameters into the vwap function call. The line that is commented out had syntax errors.

The code is optimized for fast execution by using predefined instances of the external indicator (VWAP). Not doing this is poor practice.

This oscillator does a really great job of FOLLOWING the price. While coding it was fun, I do not see how it would be useful in trading.

public class VwapOscillator2 : Indicator
{
#region Variables
private VWAP vwap1;
private bool init = false;
TimeSpan starttime, endtime;
private double vwap, sdupper, denom;
#endregion

protected override void Initialize()
{
Add(new Plot(Color.FromKnownColor(KnownColor.Orange), PlotStyle.Line, "Plot0"));
Overlay = false;
}

protected override void OnBarUpdate()
{
if (!init)
{
//endtime = new TimeSpan(0, 0, 0);
//starttime = new TimeSpan(0, 0, 0);
//vwap1 = VWAP(1, endtime, 3, 1, 2, 3, true, true, starttime);
vwap1=VWAP(Close); // define the instance of the external indicator to be used later
init = true;
}
//endtime = new TimeSpan(0, 0, 0);
//starttime = new TimeSpan(0, 0, 0);

vwap = vwap1.VWAPLine[0];
sdupper = vwap1.SD1Upper[0];
denom = sdupper - vwap;

if (denom != 0)
Value.Set((Close[0] - vwap) / denom);
else
Value.Set(0);

}

A little programming help plz

Discussion in NinjaTrader

A little programming help plz