Been at it for hours...Definitely something simple!!! AHHHHH

March 30th, 2015, 09:11 PM

I literally have been at this for hours. I have managed to get the line to be 2 solid colors no matter what I try and the fact that I know its something simple is killing me.
I trying to get the average to change colors when one of two conditions are met, then change if the opposite first or second condition is met.
Please help if its something simple, if its not let me know and ill keep trying. Maybe just some insight to get me in the right direction.

on a side note, I didn't know how to get the code on my post in the little code window that I see all over the forum. How do you do that?

{
if (High[0] > Swing(swings).SwingHigh[0]);
else if (Low[0] >= EMA(keltner)[0] + Spread * TickSize);

{
PlotColors[0][0] = sMAUp;
}
}

{
if (Low[0] < Swing(swings).SwingLow[0]);
else if (High[0] <= EMA(keltner)[0] - Spread * TickSize);

{
PlotColors[0][0] = sMADn;
}
}

March 31st, 2015, 07:11 AM

@Tanju23,

To fix your code remove the semicolon ";" from your if/else if lines:

Code

if (High[0] > Swing(swings).SwingHigh[0])
{
    // something
}
else if (Low[0] >= EMA(keltner)[0] + Spread * TickSize)
{
    PlotColors[0][0] = sMAUp;
}
if (Low[0] < Swing(swings).SwingLow[0])
{
    // something
}
else if (High[0] <= EMA(keltner)[0] - Spread * TickSize)
{
    PlotColors[0][0] = sMADn;
}

to put the code in the code box - there is a hash "#" button in the toolbar (that's where you change the fonts) - this will give you the right tags for code.

March 31st, 2015, 07:36 AM

If you are rather new to programming then I would also recommend to ALWAYS use curly braces with conditions ie: never leave the if, else if and else without accompanying curly braces. So that after closing bracket there are always curly braces (even if empty!):

Code

if (someCondition == true)
{
}
else 
{
}

This will help you to avoid many problems at the start.

March 31st, 2015, 07:36 AM

Thanks for the response. When I try what you say....

Code

{
				// If high breaks a swing high
				if (High[0] > Swing(swings).SwingHigh[0])
				// If low is greater than Keltner MB a certain # of ticks
				else if (Low[0] >= EMA(keltner)[0] + Spread * TickSize)
				
				{
					PlotColors[0][0] = sMAUp;
				}
			}
			
			{
				// If low breaks a swing low
				if (Low[0] < Swing(swings).SwingLow[0])
				// If high is less than Keltner MB a certain # of ticks
				else if (High[0] <= EMA(keltner)[0] - Spread * TickSize)
				
				{
					PlotColors[0][0] = sMADn;
				}
			}

It displays these errors. Am i not using the else if in the proper function for a comparison of the 2 conditions?

March 31st, 2015, 07:37 AM

just saw your most recent response, i will try that.

March 31st, 2015, 07:53 AM

It is not clear from your code but it seems to me that this is what you were trying to achieve:

Code

// If high breaks a swing high
if (High[0] > Swing(swings).SwingHigh[0])
{
    // If low is greater than Keltner MB a certain # of ticks
    if (Low[0] >= EMA(keltner)[0] + Spread * TickSize)
    {
        PlotColors[0][0] = sMAUp;
     }
}		
// If low breaks a swing low
if (Low[0] < Swing(swings).SwingLow[0])
{
    // If high is less than Keltner MB a certain # of ticks
    if (High[0] <= EMA(keltner)[0] - Spread * TickSize)
    {
        PlotColors[0][0] = sMADn;
    }
}

Also, you have some superfluous braces used for separation of the code (eg. before your if statement) - this is not a good practice either for a beginner - use the braces after a condition/method etc. not before:

Code

//Bad:
{
if(something)
}

//Good:
if(something)
{
}

March 31st, 2015, 08:06 AM

After separating with brackets like you said I am actually making progress.

It initially changes to magenta and should stay until one of the"up" conditions are met. Is there something that i am missing that would keep the 2 sets of conditions separate? And you guessed it, I am new to programming. Just starting to get my feet wet.

March 31st, 2015, 08:14 AM

If you want the condition to trigger to either of the 2 - you need to use or: "||"

Code

if (condition1 || condition2)
{
    //change color
}

March 31st, 2015, 08:18 AM

Thank you, gonna give that a try now.

Been at it for hours...Definitely something simple!!! AHHHHH

Discussion in NinjaTrader

Been at it for hours...Definitely something simple!!! AHHHHH