dumb piece of code, need better coding

cory · (login for full post details)

so I want to store the gap value of each session break into an array, but if I declare double array1[40] Ninja doesn't like it. Then I try to store them into a dataseries except when I go to look for the prior gap value they all get wipe out except the most current gap value, the way i store it is gap[CurrentBar] = gapValue; given gap is a dataseries.

so i end up with this dumb code, is there a better way?

Code

                            
// do gap storing into an array

            if (Cnt == 16)    {

                gap16 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);

                    dsGap[16] = gap16;

                    dsGap[15] = gap15;

                     dsGap[14] = gap14;

                    dsGap[13] = gap13;

                    dsGap[14] = gap12;

                    dsGap[12] = gap11;

                    dsGap[11] = gap10;

                      dsGap[9]= gap9;

                      dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

    

            }

                if (Cnt == 15)    {

                gap15 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);

                    dsGap[15] = gap15;

                     dsGap[14] = gap14;

                    dsGap[13] = gap13;

                    dsGap[14] = gap12;

                    dsGap[12] = gap11;

                    dsGap[11] = gap10;

                      dsGap[9]= gap9;

                      dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

    

            }

            if (Cnt == 14)    {

                gap14 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);

                  dsGap[14] = gap14;

                  dsGap[13] = gap13;

                  dsGap[12] = gap12;

                  dsGap[11] = gap11;

                    dsGap[10] = gap10;

                      dsGap[9]= gap9;

                      dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

    

            }

            if (Cnt == 13)    {

                gap13 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);

                  dsGap[13] = gap13;

                  dsGap[12] = gap12;

                  dsGap[11] = gap11;

                    dsGap[10] = gap10;

                      dsGap[9]= gap9;

                      dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

    

            }

            if (Cnt == 12)    {

                gap12 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);

                  dsGap[12] = gap12;

                  dsGap[11] = gap11;

                    dsGap[10] = gap10;

                      dsGap[9]= gap9;

                      dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

    

            }

                if (Cnt == 11)    {

                gap11 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);

                    dsGap[11] = gap11;

                    dsGap[10] = gap10;

                      dsGap[9]= gap9;

                      dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

    

            }

            if (Cnt == 10)    {

                gap10 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);

                    dsGap[10] = gap10;

                      dsGap[9]= gap9;

                      dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

    

            }

            if (Cnt == 9)    {

                gap9 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);    

                    dsGap[9]= gap9;

                      dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

            }

            if (Cnt == 8)    {

                gap8 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);    

                    dsGap[8]= gap8;

                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

            }

            if (Cnt == 7)    {

                gap7 =  Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);



                      dsGap[7]= gap7;

                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

            }

            if (Cnt == 6)    {

                gap6 =  Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);    



                      dsGap[6]= gap6;

                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

            }

            if (Cnt == 5)    {

                gap5 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);    



                      dsGap[5]= gap5;

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

            }

            if (Cnt == 4)    {

                gap4 =  Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);    

        

                      dsGap[4]= gap4;

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

            }

        

            if (Cnt == 3)    {

                gap3 = Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);    

    

                      dsGap[3]= gap3;

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

            }

                

            if (Cnt == 2)    {

                gap2 =  Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);    

    

                     dsGap[2]= gap2;

                      dsGap[1]= gap1;

            }

        

            if (Cnt == 1)    {

                gap1 =  Instrument.MasterInstrument.Round2TickSize(Open[0] - gapLast);    

                      dsGap[1]= gap1;

            }

wh · (login for full post details)

i do not know perhaps it helps ...

init from
array[0] ... array[39] has a length of 40

for(int i = 0; i < array.length; i++)
{
read me in or do somethink
}

for better understanding

Code

                            

                    dsGap[15] = gap16; 
                    dsGap[14] = gap15; 
                     dsGap[13] = gap14; 
                    dsGap[12] = gap13; 
                    dsGap[11] = gap12; 
                    dsGap[10] = gap11; 
                    dsGap[9] = gap10; 
                      dsGap[8]= gap9; 
                      dsGap[7]= gap8; 
                      dsGap[6]= gap7; 
                      dsGap[5]= gap6; 
                      dsGap[4]= gap5; 
                      dsGap[3]= gap4; 
                      dsGap[2]= gap3; 
                     dsGap[1]= gap2; 
                      dsGap[0]= gap1;

traderwerks · (login for full post details)

cory

so I want to store the gap value of each session break into an array, but if I declare double array1[40] Ninja doesn't like it. Then I try to store them into a dataseries except when I go to look for the prior gap value they all get wipe out except the most current gap value, the way i store it is

You can use double array1[40] , Ninja is fine with that.

cory · (login for full post details)

traderwerks

You can use double array1[40] , Ninja is fine with that.

no it gives me a hard time as soon as I type it in
https://content.screencast.com/users/coryng/folders/Jing/media/9ca0301c-004a-42eb-ac7e-867f5c574a0d/2010-01-20_1022.png

ps. I don't think I know how to declare an array properly.

wh · (login for full post details)

simple answer

private double[] array1 = new double[40];

or

private double[] array1 = null;

more information can be found here:

http://msdn.microsoft.com/de-de/library/9b9dty7d%28VS.80%29.aspx

know where it stands

traderwerks · (login for full post details)

cory

no it gives me a hard time as soon as I type it in

ps. I don't think I know how to declare an array properly.

I was just typing in pseudo code. I meant Ninja does not have a problem with arrays of doubles. You do have to declare/alloc arrays for your language properly before you use them. I should have been clearer.

cory · (login for full post details)

thanks, just what i need , I delete all those dumb code only 5 lines needed.

wh

simple answer

private double[] array1 = new double[40];

or

private double[] array1 = null;

more information can be found here:

Arrays (C#)

know where it stands

zeller4 · (login for full post details)

cory

thanks, just what i need , I delete all those dumb code only 5 lines needed.

that's cool, can you please share the improved version?

kz

cory · (login for full post details)

zeller4

that's cool, can you please share the improved version?

kz

the whole indicator NoGgapChart or just those 5 lines?

ps. I just remember you know your stuff so here is the whole thing.

dumb piece of code, need better coding

Discussion in NinjaTrader

dumb piece of code, need better coding

NinjaTrader Indicator Challenge!

Journal Challenge w/$1500 prizes from Topstep!

Battlestations! Show us your trading desk - $1,500 in prizes!

Call Option Buying: The New Pain Trade? w/Carley Garner