C# inline 'if' with multiple statements

August 2nd, 2012, 03:37 AM

I'm trying to do an inline if with multiple statements. I'm not sure this is possible?

int divisor = 1;
data = (!string.IsNullOrEmpty(symbol01) ? Closes[1][0] * Symbol01weight : 0) / divisor;

This is the simplest example, the actual condition is more complex.

What I want to do is change the 'true' condition to multiple statements:

Closes[1][0] * Symbol01weight; divisor++;

But I can't figure out a way to do this. At least not inline...

Thoughts? I tried Google but perhaps I am not wording it correctly, or it is impossible, because I can't find a solution (without rewriting the entire code block to not use an inline if).

Mike

August 2nd, 2012, 03:39 AM

Here is the whole block the way it exists now. Please be kind, I'm 3-years out of practice with C#. Feel free to propose a more efficient block.

Code

int divisor = 1;
if (!string.IsNullOrEmpty(symbol01)) divisor++;
if (!string.IsNullOrEmpty(symbol02)) divisor++;
if (!string.IsNullOrEmpty(symbol03)) divisor++;
if (!string.IsNullOrEmpty(symbol04)) divisor++;
if (!string.IsNullOrEmpty(symbol05)) divisor++;
if (!string.IsNullOrEmpty(symbol06)) divisor++;
if (!string.IsNullOrEmpty(symbol07)) divisor++;
if (!string.IsNullOrEmpty(symbol08)) divisor++;
if (!string.IsNullOrEmpty(symbol09)) divisor++;
if (!string.IsNullOrEmpty(symbol10)) divisor++;
data = (Closes[0][0] * Symbol00weight + (!string.IsNullOrEmpty(symbol01) ? Closes[1][0] * Symbol01weight : 0) + (!string.IsNullOrEmpty(symbol02) ? Closes[2][0] * Symbol02weight : 0) + (!string.IsNullOrEmpty(symbol03) ? Closes[3][0] * Symbol03weight : 0) + (!string.IsNullOrEmpty(symbol04) ? Closes[4][0] * Symbol04weight : 0) + (!string.IsNullOrEmpty(symbol05) ? Closes[5][0] * Symbol05weight : 0) + (!string.IsNullOrEmpty(symbol06) ? Closes[6][0] * Symbol06weight : 0) + (!string.IsNullOrEmpty(symbol07) ? Closes[7][0] * Symbol07weight : 0) + (!string.IsNullOrEmpty(symbol08) ? Closes[8][0] * Symbol08weight : 0) + (!string.IsNullOrEmpty(symbol09) ? Closes[9][0] * Symbol09weight : 0) + (!string.IsNullOrEmpty(symbol10) ? Closes[10][0] * Symbol10weight : 0))/divisor;
Aggregate.Set(data);

Mike

August 2nd, 2012, 04:16 AM

Big Mike

Here is the whole block the way it exists now. Please be kind, I'm 3-years out of practice with C#. Feel free to propose a more efficient block.

Code

int divisor = 1;
if (!string.IsNullOrEmpty(symbol01)) divisor++;
if (!string.IsNullOrEmpty(symbol02)) divisor++;
if (!string.IsNullOrEmpty(symbol03)) divisor++;
if (!string.IsNullOrEmpty(symbol04)) divisor++;
if (!string.IsNullOrEmpty(symbol05)) divisor++;
if (!string.IsNullOrEmpty(symbol06)) divisor++;
if (!string.IsNullOrEmpty(symbol07)) divisor++;
if (!string.IsNullOrEmpty(symbol08)) divisor++;
if (!string.IsNullOrEmpty(symbol09)) divisor++;
if (!string.IsNullOrEmpty(symbol10)) divisor++;
data = (Closes[0][0] * Symbol00weight + (!string.IsNullOrEmpty(symbol01) ? Closes[1][0] * Symbol01weight : 0) + (!string.IsNullOrEmpty(symbol02) ? Closes[2][0] * Symbol02weight : 0) + (!string.IsNullOrEmpty(symbol03) ? Closes[3][0] * Symbol03weight : 0) + (!string.IsNullOrEmpty(symbol04) ? Closes[4][0] * Symbol04weight : 0) + (!string.IsNullOrEmpty(symbol05) ? Closes[5][0] * Symbol05weight : 0) + (!string.IsNullOrEmpty(symbol06) ? Closes[6][0] * Symbol06weight : 0) + (!string.IsNullOrEmpty(symbol07) ? Closes[7][0] * Symbol07weight : 0) + (!string.IsNullOrEmpty(symbol08) ? Closes[8][0] * Symbol08weight : 0) + (!string.IsNullOrEmpty(symbol09) ? Closes[9][0] * Symbol09weight : 0) + (!string.IsNullOrEmpty(symbol10) ? Closes[10][0] * Symbol10weight : 0))/divisor;
Aggregate.Set(data);

Mike

You could stick it into a loop like for each symbol is empty reduce divisor by one.
But I think it would not be any more efficient, so it would probably only be for the looks.

vvhg

August 9th, 2012, 02:52 PM

Code

int divsor = 1 + new[] { symbol01, symbol02, symbol03, symbol04, symbol05, symbol06, symbol07,
symbol08, symbol09, symbol10 }.Count(s => !string.IsNullOrEmpty(s));

could you consider changing symbol01..symbol10 to string[] symbols = new string[10] ? it would simplify above to "divisor = 1 + symbols.Count(s => !string.IsNullOrEmpty(s));" :P

August 9th, 2012, 03:05 PM

Give some thought to how many times this test needs to be made and where this code is located.

Does it need to execute on every tick, on every bar, or just once (which is what it looks like to me, in which case it should be located in OnStartUp. Looks like that would require a different approach regarding what to do in response to the test.

C# inline 'if' with multiple statements

Discussion in NinjaTrader

C# inline 'if' with multiple statements