Shorter vertical line with DrawLine

April 25th, 2012, 02:02 AM

I'm currently using DrawRegion() from the top to the bottom of a Keltner Channel to highlight a bar.
I like this approach except for the fact that it offsets by half a bar.

I could be just as happy with a vertical line that runs from top to bottom of the channel but,
I can't seem to get DrawLine() to work...
At present, if the bool for autoscale is "false", the lines don't show and if "true", they do show but, run considerably higher and lower than the channel.

Example:
protected override void OnBarUpdate()
{
// Condition set 1
if (High[0] > KeltnerChannel(4, 50).Midline[0]
&& Low[0] < KeltnerChannel(4, 50).Midline[0])
{
DrawLine("My line" + CurrentBar, false, 0, KeltnerChannel(4, 50).Upper[0], 0, KeltnerChannel(4, 50).Lower[0] , Color.White, DashStyle.Solid, 2);
}
}

Here's the point where you smile and shake your head...
Go ahead, please show me the error of my ways...

Thanks in advance

May 2nd, 2012, 09:46 AM

Regarding your statement:
DrawLine("My line" + CurrentBar, false, 0, KeltnerChannel(4, 50).Upper[0], 0, KeltnerChannel(4, 50).Lower[0] , Color.White, DashStyle.Solid, 2);

I don't know if this will fix your problem, but I'd do a couple things differently.

1. The line ID "My line"+CurrentBar should be "My line" + CurrentBar.ToString().

2. You are needlessly recalculating the KeltnerChannel multiple times. To avoid this, here's what I do (and it becomes critical to speed up very complex code).

In variables, declare

Code

                            
private KeltnerChannel kc;

Add an OnStartUp() to initialize kc (don't put this in Initialize()):

Code

                            
protected override void OnStartUp() {
   kc = KelternChannel(4, 50);
}

Then in OnBarUpdate() do this:

Code

                            
protected override void OnBarUpdate() {
   double k = kc[0]; // calculate KeltnerChannel ONCE
   // now access all the properties you want
   DrawLine("Myline"+CurrentBar.ToString(), false, 0, kc.Upper[0], 0, kc.Lower[0] , Color.White, DashStyle.Solid, 2);
}

-Alex

May 3rd, 2012, 07:49 AM

anachronist,

Thank you for the response.
I wanted to let you know that I appreciate it but, can't validate it just yet.
I am in the process of re-imaging windows and reloading NinjaTrader as NT support can't duplicate the issue.
I especially appreciate the speed up suggestions & will follow up ASAP..

Shorter vertical line with DrawLine

Discussion in NinjaTrader

Shorter vertical line with DrawLine