NinjaTrader custom indicator problem with multiple data series - freezing

TraderOfFortune · (login for full post details)

Hi everybody,

I'm trying to develop an indicator that would calculate over multiple data series.

The main issue I'm having here is that after some time the indicator freezes and not only the indicator, but the whole application. Seldom it recovers from the frozen state, but most of the time it doesn't.
I can't see what I'm doing wrong.

Here's the indicator's Initialize() code:

Code

 Add(new Plot(Color.FromKnownColor(KnownColor.Red), PlotStyle.Line, "Plot0"));
			
			Add("MSFT", PeriodType.Second, 1, MarketDataType.Last);
			Add("ADBE", PeriodType.Second, 1, MarketDataType.Last);
			Add("GOOG", PeriodType.Second, 1, MarketDataType.Last);
			Add("IBM", PeriodType.Second, 1, MarketDataType.Last);
			
            Overlay				= false;

and this is the OnBarUpdate() code:

Code

			if 	(CurrentBars.Length < 5)
				return;

			double average = 0, val1 = 0, val2 = 0, val3 = 0, val4 = 0;

			var count = Math.Min(Math.Min(CurrentBars[1],CurrentBars[2]), 
								 Math.Min(CurrentBars[3], CurrentBars[4]));	
			if (count > 0)
			{
				val1+= BarsArray[1][0];
				val2+= BarsArray[2][0];
				val3+= BarsArray[3][0];
				val4+= BarsArray[4][0];
				average = (val1 + val2 + val3+ val4)/4;

				Log("Avg(" + val1 + "+" + val2 + "+" + val3+ "+"+ val4 + ")=" + average,  NinjaTrader.Cbi.LogLevel.Information);
			
				Plot0.Set(average);
			}
			else
			{
				Log("Avg(???)=undef",  NinjaTrader.Cbi.LogLevel.Information);
			
				Plot0.Set(0);
			}

Nothing too fancy, few lines of simple code.
I did try on a different PCs, and it seems that CPU speed and available memory do not affect much. In fact, memory consumption is pretty negligible.

vegasfoster · (login for full post details)

Only thing I see is that you are pulling second data. I would have the input the same as the time frame you are trading off of, so if you are trading using a 5-minute chart, then try using 5-minute data as the input. I believe this will lessen the load and not have any effect on what you are seeing. If that doesn't help or you are using a second chart to trade and need second input, then try loading fewer days.

TraderOfFortune · (login for full post details)

Thanks for the post, vegasfoster.
All data series have the same time-frame with the series on the chart. As of loading fewer days, it helps for some time, but eventually the result is the same.

Zondor · (login for full post details)

You need to use the BarsInProgress criterion to set the values of the different dataseries.

if(BarsInProgress==1) value of first ADDed data series = Closes [1][0]
if(BarsInProgress==2) value of second ADDed data series = Closes [2][0]

Code

      
      if(BarsInProgress==1) val1+= BarsArray[1][0];
      if(BarsInProgress==2) val2+= BarsArray[2][0];
      if(BarsInProgress==3) val3+= BarsArray[3][0];
      if(BarsInProgress==4) val4+= BarsArray[4][0];

You should be using try{ }catch blocks with diagnostic Print statements to show you what is going wrong during development.

You can get the value of each added data series only when the value of BarsInProgress is the one associated with that data series.

There are some examples on the Ninjatrader forum. Search it for "BarsInProgress".

etc

Fat Tails · (login for full post details)

@ Zondor: BIP is not required. I do not systematically use it for my MTF indicators as it introduces a lag. We can discuss this via private message, if you are interested.

@ TraderOfFortune:

I cannot see any real problems with your code. I have just produced a small MTF indicator, which is attached, and which runs well and without any problems on my side. It basically uses your code.

The only thing that I have added is a check for CurrentBars[0], which represents the primary bar series of the chart.

Maybe you are running into trouble because you have a slow internet connection. The indicator that I have attached is running well and without any problems here.

Chart and indicator attached.

Are you working for MultiCharts?

TraderOfFortune · (login for full post details)

Zondor, Fat Tails - many thanks for your feedback!

@Zondor: Fat Tails is right, using BIP gave the same result. Plus, it changes the logic a bit.
I did use try-catch though, as you've suggested to catch possible exceptions (not that I expected any, just to be sure) - none.

@Fat Tails: looked at your indicator - yeap, pretty close. I'm puzzled why your code works all right and mine doesn't... May be it's because you've limited the MaximumBarsLookBack?
My connection is rather fast, never had related issues before.

I'm converting indicators from EasyLanguage/PowerLanguage to Ninja and the opposite.

Fat Tails · (login for full post details)

TraderOfFortune

@ Fat Tails: looked at your indicator - yeap, pretty close. I'm puzzled why your code works all right and mine doesn't... May be it's because you've limited the MaximumBarsLookBack?
My connection is rather fast, never had related issues before.

I'm converting indicators from EasyLanguage/PowerLanguage to Ninja and the opposite.

I do not think that it is linked to MaximumBarsLookBack.

You did not publish the entire code of your indicator, so I cannot tell you where the difference lies.

TraderOfFortune · (login for full post details)

Fat Tails

I do not think that it is linked to MaximumBarsLookBack.

You did not publish the entire code of your indicator, so I cannot tell you where the difference lies.

Well, it's pretty much the indicator itself, the rest of the code is auto-generated.

Fat Tails · (login for full post details)

TraderOfFortune

Well, it's pretty much the indicator itself, the rest of the code is auto-generated.

Why don't you publish your indicator, so that somebody else can test it?

TraderOfFortune · (login for full post details)

Yes, indeed - why?

Voila - attached.

@Fat Tails: Btw, do you run 64-bit version or 32? Mine is 32-bit NT running on XP.

Fat Tails · (login for full post details)

TraderOfFortune

Yes, indeed - why?

Voila - attached.

@ Fat Tails: Btw, do you run 64-bit version or 32? Mine is 32-bit NT running on XP.

Your indicator works here as expected, and there is no freeze. I use XP 32-bit.

TraderOfFortune · (login for full post details)

All right, folks - seems the mystery is resolved (at least I hope so). A friend of mine who owns a NinjaTrader license contacted them in my behalf describing the problem. They didn't give a solution, but suggested that the problem is supposedly because of intensive logging. In fact, NinjaTrader documentation has a mentioning of this issue, as it turned out.

I'd hardly call once a sec logging too intensive, so I did some tests and found out that the system rapidly slows down when there are many logs in the Log window. I suppose, when the .NET grid used in the Log window has too many lines it doesn't perform well. So, it's not the frequency that matters, but the quantity.
The lesson I leaned for myself - clean your logs periodically, if you're using log messages and running the system for a prolonged period of time.

Thanks to everybody for helping me out!

vegasfoster · (login for full post details)

Oh yes, lather up and clean your logs you dirty, dirty...oh wait, wrong forum, sorry nm.

Fat Tails · (login for full post details)

TraderOfFortune

All right, folks - seems the mystery is resolved (at least I hope so). A friend of mine who owns a NinjaTrader license contacted them in my behalf describing the problem. They didn't give a solution, but suggested that the problem is supposedly because of intensive logging. In fact, NinjaTrader documentation has a mentioning of this issue, as it turned out.

I'd hardly call once a sec logging too intensive, so I did some tests and found out that the system rapidly slows down when there are many logs in the Log window. I suppose, when the .NET greed used in the Log window has too many lines it doesn't perform well. So, it's not the frequency that matters, but the quantity.
The lesson I leaned for myself - clean your logs periodically, if you're using log messages and running the system for a prolonged period of time.

Thanks to everybody for helping me out!

This a direct consequence of the Heisenberg Uncertainty Principle.

TraderOfFortune · (login for full post details)

Fat Tails

This a direct consequence of the Heisenberg Uncertainty Principle.

Damn, I knew I shouldn't have missed my quantum physics classes!

Big Mike · (login for full post details)

Fat Tails

Heisenberg Uncertainty Principle

TraderOfFortune

Damn, I knew I shouldn't have missed my quantum physics classes!

That's ok, the only thing I think of when I hear Heisenberg is Breaking Bad.

Mike

Fat Tails · (login for full post details)

Big Mike

That's ok, the only thing I think of when I hear Heisenberg is Breaking Bad.
Mike

That is one of the reasons that the days of US leadership in the world can be counted.

NinjaTrader custom indicator problem with multiple data series - freezing

Discussion in NinjaTrader

NinjaTrader custom indicator problem with multiple data series - freezing

NinjaTrader Indicator Challenge!

Battlestations! Show us your trading desk - $1,500 in prizes!

Importance of Finding Your Own Way w/Adam Grimes

Journal Challenge w/Jigsaw