NexusFi: Find Your Edge


Home Menu

 





PriceActionSwing discussion


Discussion in NinjaTrader

Updated
      Top Posters
    1. looks_one Silvester17 with 177 posts (570 thanks)
    2. looks_two dorschden with 99 posts (1,124 thanks)
    3. looks_3 Big Mike with 52 posts (90 thanks)
    4. looks_4 jmont1 with 51 posts (23 thanks)
      Best Posters
    1. looks_one dorschden with 11.4 thanks per post
    2. looks_two Silvester17 with 3.2 thanks per post
    3. looks_3 Big Mike with 1.7 thanks per post
    4. looks_4 sudhirc with 1.7 thanks per post
    1. trending_up 965,739 views
    2. thumb_up 2,947 thanks given
    3. group 613 followers
    1. forum 2,093 posts
    2. attach_file 615 attachments




 
Search this Thread

PriceActionSwing discussion

  #861 (permalink)
 
Rad4633's Avatar
 Rad4633 
Greensboro NC
 
Experience: Advanced
Platform: TOS/ NT Dorman
Trading: ES TF CL
Posts: 1,357 since Sep 2011
Thanks Given: 2,657
Thanks Received: 894

@dorschden

Can anyone explain how to only plot (x) numbers for the swing percentage settings.....As a example only plot 38-80...and make all other numbers not selected be transparent. Im Trying to keep a cleaner chart and I dont understand the logic to make this happen

thx in advance...this is bugging me and I cant find a solution
R

Visit my NexusFi Trade Journal Reply With Quote

Can you help answer these questions
from other members on NexusFi?
Better Renko Gaps
The Elite Circle
Are there any eval firms that allow you to sink to your …
Traders Hideout
New Micros: Ultra 10-Year & Ultra T-Bond -- Live Now
Treasury Notes and Bonds
Exit Strategy
NinjaTrader
Futures True Range Report
The Elite Circle
 
  #862 (permalink)
 
Tasker_182's Avatar
 Tasker_182 
Cedar Rapids, iowa
Legendary Market Wizard
 
Experience: Intermediate
Platform: Ninjatrader
Broker: Ninjatrader - Continuum
Posts: 716 since Aug 2009
Thanks Given: 476
Thanks Received: 1,401


Rad4633 View Post
@dorschden

Can anyone explain how to only plot (x) numbers for the swing percentage settings.....As a example only plot 38-80...and make all other numbers not selected be transparent. Im Trying to keep a cleaner chart and I dont understand the logic to make this happen

thx in advance...this is bugging me and I cant find a solution
R

So what you want to do is to evaluate the value of swing percent against a high and low number and if the percent is outside the low - high range then do not print the swing percentage or if it is inside your high and low then do print. You are also implying that the low and high values are adjustable by the user so user input will be needed.


Taking a quick look at the beauty of PriceActionswingPro code, here (I think) is the existing section of interest (under Region Swing value output)

if (showSwingPercent && curHighPercent != 0)
{
DrawText("UpPerc" + swingCounterUp, AutoScale, curHighPercent.ToString() + "%",
CurrentBar - curHighBar, curHigh, textOffsetPercent, textColor, textFont,
StringAlignment.Center, Color.Transparent, Color.Transparent, 0);
}

There is of course more than one way to do this so here is but one suggestion.

It would appear that the above section is selected by user (with the bool showSwingPercent) to display the swing percentage variable curHighPercent

If you added 3 variables (in the variable declaration section):

private bool percentInRange = false ;// Flag to say percent in user selected range to print
private double percentLow = 38 ; // Holds the user select min value for printing
private double percentHigh = 80 ; // Holds the user selected max value for printing


And then you would modify Dorchen's code to:

if (curHighPerecent >= percentLow && curHighPerecent <= percentHigh) percentInRange = true ; // okay to print

if (showSwingPercent && curHighPercent != 0 && percentInRange)
{
DrawText("UpPerc" + swingCounterUp, AutoScale, curHighPercent.ToString() + "%",
CurrentBar - curHighBar, curHigh, textOffsetPercent, textColor, textFont,
StringAlignment.Center, Color.Transparent, Color.Transparent, 0);
percentInRange = false ; // Reset flag
}

Then in the region "Properties" you would need to add two sections for the user input of percentLow and percentHigh.

Again that is one way to do it. In the interest of full disclosure I have not tried this or tested it so proceed with that in mind.

Hope this helps


EDIT: I hope I didn't misunderstand, I offered help based on that you did not want to display the percentage.

2nd Edit: You would need to do the same thing for the other side as well.

Be yourself; everyone else is already taken. Oscar Wilde
Reply With Quote
  #863 (permalink)
 
Tasker_182's Avatar
 Tasker_182 
Cedar Rapids, iowa
Legendary Market Wizard
 
Experience: Intermediate
Platform: Ninjatrader
Broker: Ninjatrader - Continuum
Posts: 716 since Aug 2009
Thanks Given: 476
Thanks Received: 1,401



Tasker_182 View Post
So what you want to do is to evaluate the value of swing percent against a high and low number and if the percent is outside the low - high range then do not print the swing percentage or if it is inside your high and low then do print. You are also implying that the low and high values are adjustable by the user so user input will be needed.


Taking a quick look at the beauty of PriceActionswingPro code, here (I think) is the existing section of interest (under Region Swing value output)

if (showSwingPercent && curHighPercent != 0)
{
DrawText("UpPerc" + swingCounterUp, AutoScale, curHighPercent.ToString() + "%",
CurrentBar - curHighBar, curHigh, textOffsetPercent, textColor, textFont,
StringAlignment.Center, Color.Transparent, Color.Transparent, 0);
}

There is of course more than one way to do this so here is but one suggestion.

It would appear that the above section is selected by user (with the bool showSwingPercent) to display the swing percentage variable curHighPercent

If you added 3 variables (in the variable declaration section):

private bool percentInRange = false ;// Flag to say percent in user selected range to print
private double percentLow = 38 ; // Holds the user select min value for printing
private double percentHigh = 80 ; // Holds the user selected max value for printing


And then you would modify Dorchen's code to:

if (curHighPerecent >= percentLow && curHighPerecent <= percentHigh) percentInRange = true ; // okay to print

if (showSwingPercent && curHighPercent != 0 && percentInRange)
{
DrawText("UpPerc" + swingCounterUp, AutoScale, curHighPercent.ToString() + "%",
CurrentBar - curHighBar, curHigh, textOffsetPercent, textColor, textFont,
StringAlignment.Center, Color.Transparent, Color.Transparent, 0);
percentInRange = false ; // Reset flag
}

Then in the region "Properties" you would need to add two sections for the user input of percentLow and percentHigh.

Again that is one way to do it. In the interest of full disclosure I have not tried this or tested it so proceed with that in mind.

Hope this helps


EDIT: I hope I didn't misunderstand, I offered help based on that you did not want to display the percentage.

2nd Edit: You would need to do the same thing for the other side as well.


At the risk of quoting myself, I have quoted myself...

After reviewing the modifications it became apparent that the changes I recommended would not work as originally requested. Briefly, I had forgotten that as the swing developed all of the swing info is readjusted and shifted to match up with the latest high or low which could be the next bar or several more bars. With the code I provided what would happen is that as long as the swing percentage was within the specified limits it would print but as soon as it went out of the limits it would no longer print and while that sounds like what was requested in reality is that the last percentage that was within the limit would stay on the chart but it might be in the middle of the swing!! Again the reason for that is that was the last place (within the swing) it was within limits.

But that is not how the requestor wanted it to work. He clearly only wanted to see the final swing percentages within his limit specification. So here is the original code and the modifications to make it work, shown in RED

Original code in BLUE

if (showSwingPercent && curLowPercent != 0)
{
DrawText("DnPerc" + swingCounterDn, AutoScale, curLowPercent.ToString() + "%",
CurrentBar - curLowBar, curLow, -textOffsetPercent, textColor, textFont,
StringAlignment.Center, Color.Transparent, Color.Transparent, 0);
}


//Again original in blue and modified/added in RED

if (showSwingPercent && curLowPercent != 0)
{

if (curLowPercent >= limitPercentageLow && curLowPercent <= limitPercentageHigh) // Only print when in range
{

DrawText("DnPerc" + swingCounterDn, AutoScale, curLowPercent.ToString() + "%",
CurrentBar - curLowBar, curLow, -textOffsetPercent, textColor, textFont,
StringAlignment.Center, Color.Transparent, Color.Transparent, 0);
}

else
{
RemoveDrawObject("DnPerc" + swingCounterDn) ;
}



So be aware that as the swing is developing, if the percentage falls outside of the user defined limits/range, the percentage will disappear.

NOTE: 1 - The added variables limitPercentageLow and limitPercentageHigh would be identified in the variable section as Double.

Note: 2 - This example covers only the downswing, similar code is needed in the upswing section


Be yourself; everyone else is already taken. Oscar Wilde
Reply With Quote
  #864 (permalink)
 jmont1 
New York, NY
 
Experience: Intermediate
Platform: NinjaTrader8
Broker: Data = Rithmic -- Gives 70 Level II Data
Trading: 6C (Low Margin,) 6E, CL, GC, ES and Maybe DX for smaller tick value
Posts: 1,394 since May 2011
Thanks Given: 1,719
Thanks Received: 1,019

This request is originally posted in the "free incicator" thread.

@traderpards helped by fixing the specific strategy. But it would be much better if the fix was in the PASwingPro indicator so it could easily be plugged into multiple strategies without the editing.

Wizard generated strategies cannot be manually edited and then continued with the wizard. So once the stratgy is fixed it cannot be modified by Wizard.

May I request someone take a look at the previous post referenced below that includes the attachments? It would be a great help. THANK YOU!


jmont1 View Post
Trying to use PriceActionSwingPro in a strategy (generated by Wizard) but the strategy will not compile due to what appears to be a naming convention in PASwingPro. Can someone review this strategy to see the error? Then look at PAS to see how it could be modified?

Attaching the Strategy PASwingProNo and the PASwingPro CS files I am using because I am not sure if it is at all different from the standard posting.

P.S. Since the strategy fails - you will need to delete it before being able to import other indicators or you will continue to get failures on compiling.

THANK YOU!


Reply With Quote
Thanked by:
  #865 (permalink)
shanemcdonald28
new york
 
Posts: 355 since Mar 2012
Thanks Given: 665
Thanks Received: 582

I stumbled upon this while looking around for a wyckoff wave volume type of indicator.
I must say this is a fabulous piece of work.
My hat is off to you.

Thank you for your hard work and sharing. It is excellent.

thanks
Shane

Reply With Quote
  #866 (permalink)
stok
Dallas
 
Posts: 11 since Jul 2011
Thanks Given: 2
Thanks Received: 3

Is there anyway PASPro can duplicate what is in this chart (it's zigzag, but swing highs to swing highs and swing lows to swing lows) ?

Attached Thumbnails
Click image for larger version

Name:	ES08.jpg
Views:	303
Size:	45.5 KB
ID:	133530  
Reply With Quote
Thanked by:
  #867 (permalink)
 supermht 
Naperville IL
 
Experience: Intermediate
Platform: ninjatrader
Broker: NT broker
Trading: NQ ES 6E GC CL
Posts: 962 since Feb 2010
Thanks Given: 1,189
Thanks Received: 661

can anyone add the function of calculating swing time/points by close? currently the indicator calculates swing time/points by High and Low. thanks

Reply With Quote
  #868 (permalink)
 motyalt 
israel
 
Experience: Beginner
Platform: ninjatrader
Broker: zen fire
Trading: NQ
Posts: 8 since Sep 2010
Thanks Given: 9
Thanks Received: 1

can a sound file be added for db and dt ?

Reply With Quote
  #869 (permalink)
 
Rachel's Avatar
 Rachel 
San Diego
 
Experience: Advanced
Platform: Private
Broker: private
Trading: CL future
Posts: 1,380 since Mar 2012
Thanks Given: 935
Thanks Received: 1,955


motyalt View Post
can a sound file be added for db and dt ?

LH and HL?

Pretty Please,

Rachel

Visit my NexusFi Trade Journal Reply With Quote
Thanked by:
  #870 (permalink)
 
Tasker_182's Avatar
 Tasker_182 
Cedar Rapids, iowa
Legendary Market Wizard
 
Experience: Intermediate
Platform: Ninjatrader
Broker: Ninjatrader - Continuum
Posts: 716 since Aug 2009
Thanks Given: 476
Thanks Received: 1,401



Tasker_182 View Post
At the risk of confusion, I will copy my post and files from the elite indicator thread to here for reference.

"In @dorschden priceaction swing thread, Nicetrade wrote: My previous request for adding audio alert in divergence may be too much since the divergence signal keeps moving till fixed so that might be too many alerts. Then please just add an audio alert for DT/DB with sound file selectable from my hard drive since


Dorschden replied: @nicetrade, I can't promise anything, but maybe in October I'll add the option to use alerts for different things. Until then maybe somebody else can help you.

With apologies to @dorschden (beautiful code bludgeoned by my intrusion) I have modified PriceActionSwingPro. I added one bool to turn on voice alerts for DT/DB, I added two inputs for two separate sound files, I added the simple Playsound in the area when the labels are, so as a result DB/DT labels must be turned on as well. I also created two voice alerts which can be placed anywhere or if you prefer you can use your own sounds. Whichever you use, you will need to input the complete path and filename, for each sound.

With apologies to @jmont1, exposure is something with which i am unfamiliar, thus not my paygrade.

I'm not sure how this will install with the existing PriceactionSwingPro. It is possible that you may have to remove the .CS file and replace it with the one in the attached zip and then recompile."

Regards.


motyalt View Post
can a sound file be added for db and dt ?

I've already done this. Click on the Tasker_182 blue quote button above and it will take you to the quoted post with the indicator and even sound files. Sorry does not include LH or LL or HH or HL

Be yourself; everyone else is already taken. Oscar Wilde
Reply With Quote
Thanked by:




Last Updated on January 7, 2024


© 2024 NexusFi™, s.a., All Rights Reserved.
Av Ricardo J. Alfaro, Century Tower, Panama City, Panama, Ph: +507 833-9432 (Panama and Intl), +1 888-312-3001 (USA and Canada)
All information is for educational use only and is not investment advice. There is a substantial risk of loss in trading commodity futures, stocks, options and foreign exchange products. Past performance is not indicative of future results.
About Us - Contact Us - Site Rules, Acceptable Use, and Terms and Conditions - Privacy Policy - Downloads - Top
no new posts