Math.Max, Max help with int

October 17th, 2015, 01:42 PM

Need some NinjaScript help!

so I have 10 conditions (bool) ranging from c1 - c10.
if any of those conditions are true, then they give me the appropriate int.
ex. if c1 is true, then m2 = 3.

This is all under BarUpdate()

int m2 = c1 ? 3 : 0;
int m3 = c2 ? 4 : 0;
int m4 = c3 ? 5 : 0;
int m5 = c4 ? 6 : 0;
int m6 = c5 ? 7 : 0;
int m7 = c6 ? 8 : 0;
int m8 = c7 ? 9 : 0;
int m9 = c8 ? 10 : 0;
int m10 = c9 ? 11 : 0;
int m11 = c10 ? 12 : 0;

int max1 = Max(m2, m3);
int max2 = Max(max1, m4);
int max3 = Max(max2, m5);
int max4 = Max(max3, m6);
int max5 = Max(max4, m7);
int max6 = Max(max5, m8);
int max7 = Max(max6, m9);
int max8 = Max(max7, m10);
int max9 = Max(max8, m11);

int maxcondition = max9;

Now, what I want to do is have maxcondition extract the highest value between m1 - m11, by using the max function (max1 - max9).

However, I get the following error:

the name 'max' does not exist in the current context.

The errors are on ints max1- max9

Thanks in advance.

October 17th, 2015, 01:55 PM

Try Math.Max() and not Max().

And using an array of int would have been better...

October 17th, 2015, 01:58 PM

sam028

Try Math.Max() and not Max().

Awesome!
Worked.

- Working around the ThinkScript version.

Thank you!

October 17th, 2015, 02:18 PM

I shouted glory too soon. Is all my coding correct?
It doesn't produce any more errors, but it also doesn't draw a trendline.
The trendline when placed in a fresh new indicator under BarUpdate, works fine alone.

However, when I introduce the bools, and ints, and max ints, it does not.

What am I doing wrong?

October 17th, 2015, 03:02 PM

kidvic

I shouted glory too soon. Is all my coding correct?
It doesn't produce any more errors, but it also doesn't draw a trendline.
The trendline when placed in a fresh new indicator under BarUpdate, works fine alone.

However, when I introduce the bools, and ints, and max ints, it does not.

What am I doing wrong?

make sure you have enough bars before plotting a line

for example you are looking for max of 5 bars then wait for 5 bar values first thus;

protected override void OnBarUpdate()
{
// wait for 5 bar values before plotting
if (CurrentBar < 5)
return;

October 17th, 2015, 03:14 PM

cory

make sure you have enough bars before plotting a line

for example you are looking for max of 5 bars then wait for 5 bar values first thus;

protected override void OnBarUpdate()
{
// wait for 5 bar values before plotting
if (CurrentBar < 5)
return;

Thank you for that, I started commenting out the code, and I have come to this:

Help with Bool in indicator.

Can a bool have too many conditions where the script just won't work?

for example.
somecondition will always be different.

bool C1 = "somecondition" && "somecondition";

all the way up too..... …

The rest of the code is working, its just some bools are what are causing the issue.

Math.Max, Max help with int

Discussion in NinjaTrader

Math.Max, Max help with int