Been at it for hours...Definitely something simple!!! AHHHHH

March 31st, 2015, 08:40 AM

Its coloring when it is supposed to but it seems only when the conditions are met. Is there a way to "latch" it to stay until the opposite is met?

March 31st, 2015, 08:52 AM

Here is another example. In the pic It shows a magenta and should change to cyan when the highs break the swing

March 31st, 2015, 09:05 AM

You need to add one more color variable eg.:

Code

private Color useThisColor = Color.White;  //just setting up some default

then OnBarUpdate:

Code

if (conditionsUpAreMet)
{
    useThisColor = sMAUp;
}
if (conditionsDownAreMet)
{
    useThisColor = sMADn;
}

// and at the bottom:
PlotColors[0][0] = useThisColor;

April 2nd, 2015, 12:29 PM

Just wanted to give you an update. Your guidance paid off and its doing what it is supposed to do!! Thank you again!

April 13th, 2015, 07:02 PM

You helped me get the indicator working great, been using it for a few weeks now with success. Now I'm attempting an automated entry.

Here is my generic code for the purpose of illustration.

Code

// Condition set 1
            if (MyTML(Weighted, MB, TMl, 5, 8).TMLUp[1] < MyTML(Weighted, MB, TMl, 5, 8).TMLUp[0]
                && MyMACDBBLines(10, 12, 26, 1).BBMACD[0] > MyMACDBBLines(10, 12, 26, 1).Upper[0])
                
            {
                EnterLong(Contracts, "");
            }

For some reason even though I am saying only "Up", as you can see it is entering on the "Down" indication as well. Any insight would be appreciated. Also, I have to use the indicator on COBC true because it doesn't work quite right with it on false. Probably a separate issue but just throwing all my delimas out there. Thank you to anyone in advanced.

April 13th, 2015, 07:50 PM

Tanju23

For some reason even though I am saying only "Up", as you can see it is entering on the "Down" indication as well. Any insight would be appreciated. Also, I have to use the indicator on COBC true because it doesn't work quite right with it on false. Probably a separate issue but just throwing all my delimas out there. Thank you to anyone in advanced.

Welcome back

The reason because COBC false doesn't work quite well for you is probably because the values of the indicators change intrabar (ie: during a bar creation you can have: Up, Down, Up, Down, etc.).

As to your main problem in your condition you compare TMLUp[1] and TMLUp[0], but what are the values of TMLUp - Is it possible that the line will be colored down even though [0] is greater than [1]?

I would recommend adding some Print statements eg.

Code

Print("TMLUp[1]: "+MyTML(Weighted, MB, TMl, 5, 8).TMLUp[1]);

for all the values so you could check if the condition is what you expect.

April 13th, 2015, 07:56 PM

What are the print statements for?

Would posting the code for the indicator you helped me create help you see an issue?

April 13th, 2015, 08:05 PM

Print will print the message you want into the output window. You can open Output Window from Control Center (Tools) or from NinjaScript code editor (4th icon from the left on the toolbar)

April 13th, 2015, 08:14 PM

yeah it looks like up is being recognized for the whole indicator, how do i get it to just be set with the plots up and down?

here is the indicator. What can you see that I could change...if anything.

Code

protected override void Initialize()
        {
            Add(new Plot(new Pen(Color.Cyan,2), "TMLUp"));
          	Add(new Plot(new Pen(Color.Magenta,2), "TMLDn"));
            Overlay				= true;
			PriceTypeSupported	= false;
			PlotsConfigurable   = true;
			CalculateOnBarClose = false;
			
        }
		
		protected override void OnStartUp()
		
		{
			Plots[0].PlotStyle = plot0Style;
			Plots[0].Pen.DashStyle = dash0Style;
			Plots[1].PlotStyle = plot1Style;
			Plots[1].Pen.DashStyle = dash1Style;
		}

        /// <summary>
        /// Called on each bar update event (incoming tick)
        /// </summary>
        protected override void OnBarUpdate()
        {
            
			// Are there enough bars
			if (CurrentBar < Period) return;
			
						
			// Calculations
			TMLUp.Set(LinReg(Input,period)[0]);
            TMLDn.Set(LinReg(Input,period)[0]);
			{
				// If high breaks a swing high
				if (High[0] > Swing(swings).SwingHigh[0] || Low[0] >= EMA(Keltner)[0] + Spread * TickSize)
				{
					useThisColor = tMLUp;
				}
			}
			
			{
				// If low breaks a swing low
				if (Low[0] < Swing(swings).SwingLow[0] || High[0] < EMA(keltner)[0] - spread * TickSize)
				{
					useThisColor = tMLDn;
				}
				
				
				PlotColors[0][0] = useThisColor;

April 14th, 2015, 06:58 AM

Your TMLUp and TMLDown seem to be nothing else than just a reference to the same LinReg. If your goal for TMLUp and TMLDown is to only represent binary result (it is either Up or Down, 1 or -1) then you need one additional dataseries TML and temp int, eg.: private int tempTML = 0;
Then in your code just as you did with color:

Code

// Calculations
TMLUp.Set(LinReg(Input,period)[0]);
TMLDn.Set(LinReg(Input,period)[0]);

// If high breaks a swing high
if (High[0] > Swing(swings).SwingHigh[0] || Low[0] >= EMA(Keltner)[0] + Spread * TickSize)
{
    useThisColor = tMLUp;
    tempTML = 1;
}

// If low breaks a swing low
if (Low[0] < Swing(swings).SwingLow[0] || High[0] < EMA(keltner)[0] - spread * TickSize)
{
    useThisColor = tMLDn;
    tempTML = -1;
}

TML.Set(tempTML);

In your strategy you can then ask for:

Code

if((YourIndicator.TML[0] == 1) 
{
    EnterLong();
}
if(YourIndicator.TML[0] == -1) 
{
    EnterShort();
}

As already mentioned before remove the {} that are not following a method, condition or property details - this is really bad habit and makes the code unreadable - there is no benefit and high cost to using them.

Been at it for hours...Definitely something simple!!! AHHHHH

Discussion in NinjaTrader

Been at it for hours...Definitely something simple!!! AHHHHH