Can I add existing indicators to an indicator I am creating?

July 16th, 2011, 09:17 PM

forrestang

WTF?

Wanted to change the display name of the indie to something different. Then Bam! All my colors changed, and now nothing shows up in my indie pane. WTF?

I think it's one of those errors due to not having enough data? No compiling errors, but I see this in my output.

July 16th, 2011, 10:53 PM

It looks like this is my problem.

Checking for Null References - [AUTOLINK]NinjaTrader[/AUTOLINK] Support Forum

Some null crap. I don't even know what that means. Aaaaaargh!!!!!!

July 17th, 2011, 02:16 AM

May have gotten somewhere?

Deleted the 'if' statements at the beginning of onBarUpdate and I have my indicator working. Still need to poke around though.

Notice the commented lines. Not sure why that was there originally, but it must have had some purpose?

Code

if (CurrentBar < 1)
       {
              //if (swingRelation == null && seeRelation)
               swingRelation = PriceActionSwing(Input, dtbStrength, swingSize, swingType).SwingRelation;
				
              //if (swingTrend == null && !seeRelation)
              swingTrend = PriceActionSwing(Input, dtbStrength, swingSize, swingType).SwingTrend;

Woot!!!

July 17th, 2011, 11:50 AM

Finally got this P.O.S. indie doing what I want for the most part!

Also added the necessary dataSeries to get this thing to work with Market Analyzer.

July 18th, 2011, 03:02 AM

More random thoughts.....

Cleaning up the script. I have stuff everywhere.

Also need to clean up the user input interface..... wtf is there no way to reorder things the way you want other than renaming things so it shows in alphabetical order?

That is kinda annoying.

July 18th, 2011, 04:04 AM

New idea......

The trading I'm doing is partially dependent on pullbacks to the 13ma. And attached is a picture of what my Market Analyzer looks like now.

Right now I will usually consider a pb complete if price gets a minimum of 2 tics within that ma to begin to look for a trade. So typically once it gets there, I start putting my cross hair on that bar, and looking at the values of the H/L of that bar and the 13ema to see if it's right.

I'm thinking I can add that in the indicator, so that when price is within 2 tics of that ma, I can have it displayed in Market Analyzer.

Then the problem would be if I use a different value for a different instrument. CL for example I would give it 4 tics since it moves faster.

Hmmmm..........?

July 18th, 2011, 04:24 AM

forrestang

More random thoughts.....

Cleaning up the script. I have stuff everywhere.

Also need to clean up the user input interface..... wtf is there no way to reorder things the way you want other than renaming things so it shows in alphabetical order?

That is kinda annoying.

You can use numbers at the start of the Display name.

July 18th, 2011, 04:29 AM

futuretrader

You can use numbers at the start of the Display name.

Good idea. I used the letter "A" in previous studies.... but the numbers are an even better idea.

Here's another thought, something I haven't tried yet but i will later when i shut down my charts.

But you know in the properties when you define the "parameters' block where most things show up. What if you named some parameters to say "Parameters 1" and the others to "Parameters 2?"

And you do this for each different indicator your study references? Say my indicator is based mainly on the ichiCloud and the the ZZ indicator.

So what if I saved one set of parameters as maybe "Parameters-ichi" and the others to "Parameters-ZigZag"

Have you seen this tried before?

July 18th, 2011, 04:33 AM

futuretrader

You can use numbers at the start of the Display name.

Just to clarify, do you mean that I can leave my variables the same way they are declared in my 'variables' section up top. And just change the name down at the bottom?

From This:

Code

[Browsable(false)]	// this line prevents the data series from being displayed in the indicator properties dialog, do not remove
        [XmlIgnore()]		// this line ensures that the indicator can be saved/recovered as part of a chart template, do not remove
        public DataSeries TrendState
        {
            get { return trendState; }
        }

To this:

Code

[Browsable(false)]	// this line prevents the data series from being displayed in the indicator properties dialog, do not remove
        [XmlIgnore()]		// this line ensures that the indicator can be saved/recovered as part of a chart template, do not remove
        public DataSeries 1_TrendState
        {
            get { return trendState; }
        }

July 18th, 2011, 04:33 AM

forrestang

Good idea. I used the letter "A" in previous studies.... but the numbers are an even better idea.

Here's another thought, something I haven't tried yet but i will later when i shut down my charts.

But you know in the properties when you define the "parameters' block where most things show up. What if you named some parameters to say "Parameters 1" and the others to "Parameters 2?"

And you do this for each different indicator your study references? Say my indicator is based mainly on the ichiCloud and the the ZZ indicator.

So what if I saved one set of parameters as maybe "Parameters-ichi" and the others to "Parameters-ZigZag"

Have you seen this tried before?

I haven't seen that but it seems a good idea in an indicator that combines several others like yours. Though in your case I doubt anyone would want to play around with the ichi parameters - I think that could drive you mad.

Can I add existing indicators to an indicator I am creating?

Discussion in NinjaTrader

Can I add existing indicators to an indicator I am creating?