Want to create an indicator and have no idea where to start?

June 1st, 2011, 09:36 AM

For example, here is the code snippet to generate one of the buy signals, which at the moment is just an UpArrow. Initially I was thinking you would have to have a parity bit or flag that would trigger to some value upon this arrow being printed. That was the idea behind that variable I have there called "inTrade."

I was thinking I'd add another IF statement outside of that block where the UpArrow is printed to check to see if inTrade==true, and if it is, means we are in a trade so check to see if sell condition is met.

Code

//1a_A Trade
			
			if(ERG_Trade().Ltsx[0] == 1 && ERG_Str1().HISTSlope[0] == 1 && ERG_Trade().HIST[0] >= 10 )
			{
				if(ERG_Trade().HISTSlope[1] == 1 && ERG_Trade().HISTSlope[2] == 1 && ERG_Trade().HISTSlope[3] == -1)
				{	
				DrawArrowUp("arrow"+CurrentBar, true, 0, Low[0]-12*TickSize, Color.Green);
				DrawText("text0"+CurrentBar, ""+Open.ToString(), 0, Low[0]-30*TickSize, Color.Black);
				DrawText("text1"+CurrentBar ,"1a_A", 0, Low[0]-38*TickSize, Color.Black);
				inTrade = true;			
				}
				
			}

June 1st, 2011, 10:31 AM

forrestang

For example, here is the code snippet to generate one of the buy signals, which at the moment is just an UpArrow. Initially I was thinking you would have to have a parity bit or flag that would trigger to some value upon this arrow being printed. That was the idea behind that variable I have there called "inTrade."

I was thinking I'd add another IF statement outside of that block where the UpArrow is printed to check to see if inTrade==true, and if it is, means we are in a trade so check to see if sell condition is met.

Code

//1a_A Trade
			
			if(ERG_Trade().Ltsx[0] == 1 && ERG_Str1().HISTSlope[0] == 1 && ERG_Trade().HIST[0] >= 10 )
			{
				if(ERG_Trade().HISTSlope[1] == 1 && ERG_Trade().HISTSlope[2] == 1 && ERG_Trade().HISTSlope[3] == -1)
				{	
				DrawArrowUp("arrow"+CurrentBar, true, 0, Low[0]-12*TickSize, Color.Green);
				DrawText("text0"+CurrentBar, ""+Open.ToString(), 0, Low[0]-30*TickSize, Color.Black);
				DrawText("text1"+CurrentBar ,"1a_A", 0, Low[0]-38*TickSize, Color.Black);
				inTrade = true;			
				}
				
			}

Please, always remember to update the indicator as contained in post #18.

Lolu

June 1st, 2011, 10:50 AM

forrestang

That was the idea behind that variable I have there called "inTrade."

I was thinking I'd add another IF statement outside of that block where the UpArrow is printed to check to see if inTrade==true, and if it is, means we are in a trade so check to see if sell condition is met.

Got it!

I did what I suggested above. Problem is that I have to do this for every individual trade scenario I have, and there are over 200 of them.

Here is the code snippet. I added that flag I spoke of above, so that it only triggers AFTER the entry condition is satisfied.

Code

if(ERG_Trade().Ltsx[0] == 1 && ERG_Str1().HISTSlope[0] == 1 && ERG_Trade().HIST[0] >= 10 )
			{
				if(ERG_Trade().HISTSlope[1] == 1 && ERG_Trade().HISTSlope[2] == 1 && ERG_Trade().HISTSlope[3] == -1)
				{	
				DrawArrowUp("arrow"+CurrentBar, true, 0, Low[0]-12*TickSize, Color.Green);
				DrawText("text0"+CurrentBar, ""+Open.ToString(), 0, Low[0]-30*TickSize, Color.Black);
				DrawText("text1"+CurrentBar ,"1a_A", 0, Low[0]-38*TickSize, Color.Black);
				inTrade_1a_A = 1;			
				}
				
				if(inTrade_1a_A == 1 && ERG_Trade().HISTSlope[1] == -1)
				{	
				DrawArrowDown("arrow"+CurrentBar, true, 0, High[0]+12*TickSize, Color.Black);
				DrawText("text2"+CurrentBar, ""+Open.ToString(), 0, High[0]+30*TickSize, Color.Black);
				inTrade_1a_A = 0;			
				}
			}

June 1st, 2011, 10:56 AM

lolu

Please, always remember to update the indicator as contained in post #18.

Lolu

I think it should be? I'm pretty sure I posted it earlier this morning?

June 1st, 2011, 11:34 AM

forrestang

Got the logic done and it's doing what I want.

Is there a simple way to add a closing arrow to this? Does NT have some function built in so that once my green/red arrow prints to show my entry, I can plot an exit AFTER that entry arrow?

Asking as eventually I'll want to kick this out to a strategy.

if you convert it into a strategy, it draws arrows for entry and exit for you. You can very this by applying sample strategy ma cross, enable = true and you will see arrows on your chart.

Code

		protected override void OnBarUpdate()
		{
			if (CrossAbove(SMA(Fast), SMA(Slow), 1))
			    EnterLong();
			else if (CrossBelow(SMA(Fast), SMA(Slow), 1))
			    EnterShort();
		}

June 1st, 2011, 11:53 AM

cory

if you convert it into a strategy, it draws arrows for entry and exit for you. You can very this by applying sample strategy ma cross, enable = true and you will see arrows on your chart.

Excellent!

Since I have it setup when to draw an arrow up, and attached to it already is the exit.... so basically all I would need to do is replace the logic for drawing the arrows and the text I have with the "EnterLong()/EnterShort()" short commands?

Is there a command for exiting the signals, or do you just enter "EnterShort()" to exit a long trade for example?

Also, when I do create a strategy for this, if I have over 200 individual setups that I want to collect statistics for individually, do I have to individually toggle them on/off in the script and then test? Or will that be taken care of in the "signalName" parameter in the EnterLong()? Or is "signalName" just for visual reference on the chart?

NinjaTrader Version 7

June 1st, 2011, 12:06 PM

forrestang

Is there a command for exiting the signals, or do you just enter "EnterShort()" to exit a long trade for example?

Ah, found the ExitLong() command and connecting it to the entry via 'signalName' parameter.

June 1st, 2011, 12:38 PM

forrestang

For example, here is the code snippet to generate one of the buy signals, which at the moment is just an UpArrow. Initially I was thinking you would have to have a parity bit or flag that would trigger to some value upon this arrow being printed. That was the idea behind that variable I have there called "inTrade."

I was thinking I'd add another IF statement outside of that block where the UpArrow is printed to check to see if inTrade==true, and if it is, means we are in a trade so check to see if sell condition is met.

Code

//1a_A Trade
			
			if(ERG_Trade().Ltsx[0] == 1 && ERG_Str1().HISTSlope[0] == 1 && ERG_Trade().HIST[0] >= 10 )
			{
				if(ERG_Trade().HISTSlope[1] == 1 && ERG_Trade().HISTSlope[2] == 1 && ERG_Trade().HISTSlope[3] == -1)
				{	
				DrawArrowUp("arrow"+CurrentBar, true, 0, Low[0]-12*TickSize, Color.Green);
				DrawText("text0"+CurrentBar, ""+Open.ToString(), 0, Low[0]-30*TickSize, Color.Black);
				DrawText("text1"+CurrentBar ,"1a_A", 0, Low[0]-38*TickSize, Color.Black);
				inTrade = true;			
				}
				
			}

MarketPosition

Definition
Gets the current market position.

Property Value

MarketPosition.Flat

MarketPosition.Long

MarketPosition.Short

Syntax

Position.MarketPosition

Examples

Code

protected override void OnBarUpdate()
{ 
    // If not flat print our open PnL
    if (Position.MarketPosition != MarketPosition.Flat) 
         Print("Open PnL: " + Position.GetProfitLoss(Close[0], PerformanceUnit.Points));
}

June 1st, 2011, 12:44 PM

forrestang

Ah, found the ExitLong() command and connecting it to the entry via 'signalName' parameter.

You can also tie your strategy to an "ATM" strategy and let it handle the Stops and Targets for you.

SampleATMstrategy.zip

June 1st, 2011, 02:07 PM

Ah shucks!

My exit logic is off. Printing some erroneous arrows along with leaving some of them out.

Want to create an indicator and have no idea where to start?

Discussion in NinjaTrader

Want to create an indicator and have no idea where to start?