How to make SMA coloured histogram ?

May 15th, 2011, 01:51 PM

Hi,

I want to make coloured SMA histogram for BuySellStrength by tulanch.
Indicator you can find: NinjaTrader Support Forum > Links and Downloads Manager > Version 7 Indicators

Question is: How to make the histogram value higher than zero to have a green colour, and for values lower than zero to have a red colour?

I modified the BuySellStrength indicator by adding:
// needed for the average

Code

Add(new Plot(Color.FromKnownColor(KnownColor.Green), PlotStyle.Line, "BP"));

and

Code

Plot2.Set(buysellstrength);

----------------------------------------
and SMA indicator by adding:
// to illustrate the value higher and lower than zero

Code

Add(new Line(Color.FromKnownColor(KnownColor.Black), 0, "Zero"));

The result can be seen in the attached file. There are no colours which I wrote about. Can sombody help me?

Regards,

May 15th, 2011, 02:30 PM

Best you post the indicator file. Otherwise you need to add something like

Code

if (Values[1] >= 0)
    PlotColors[1][0] = Color.Lime;
else
    PlotColors[1][0] = Color.Red;

If you edit the indicator code below you will get an idea, how to make the colors user selectable.

May 15th, 2011, 03:57 PM

I only need to modify BPSMA indicator. BPSMA is just a SMA standard ninjatrader indicator. I only added zero line:

Code

Add(new Line(Color.FromKnownColor(KnownColor.Black), 0, "Zero"));

I just want to modify the usual SMA (which can be found including standard indicators) for a value greater than zero have a green color and the lower value of zero have a red bar color.

My input series for SMA indicator (BPSMA) is: BuySellStrength indicator with Plot "BP", but it could be anything else.
BP is just a variable from BuySellStrength indicator:

Code

protected override void Initialize()
{
// ...
Add(new Plot(Color.FromKnownColor(KnownColor.Green), PlotStyle.Line, "BP"));
// ...
}

Code

protected override void OnBarUpdate()
{

if (CurrentBar < 1)
return;

long bidvol = GetCurrentBidVolume();
long askvol = GetCurrentAskVolume();

int buysellstrength =  (int) askvol - (int) bidvol;

Plot2.Set(buysellstrength);
}

So, I take variable BP and make SMA but would be nice to see the effect of green bars> 0 and red <0, only by modifying SMA indicator.

UPDATE: 2011-05-16
Fix BPSMA to show if SMA > 0 then green else red.

May 15th, 2011, 04:42 PM

To color the SMA, just add

Code

if (Values[0] >= 0)
    PlotColors[0][0] = Color.Lime;
else
    PlotColors[0][0] = Color.Red;

to OnBarUpdate().

May 15th, 2011, 05:16 PM

Fat Tails

To color the SMA, just add

Code

if (Values[0] >= 0)
    PlotColors[0][0] = Color.Lime;
else
    PlotColors[0][0] = Color.Red;

to OnBarUpdate().

Compile Error: Can not use the operator "> =" to the arguments of operations such as "NinjaTrader.Data.DataSeries" or "int".
CS0019: Error Code Explanation
Strings cannot be compared with relational operators (<, >, <=, >=, ==, !=) to other object types. Strings can only be compared to other strings and only through the use of equality operators (==, !=).

May 15th, 2011, 05:39 PM

inmax

Compile Error: Can not use the operator "> =" to the arguments of operations such as "NinjaTrader.Data.DataSeries" or "int".
CS0019: Error Code Explanation
Strings cannot be compared with relational operators (<, >, <=, >=, ==, !=) to other object types. Strings can only be compared to other strings and only through the use of equality operators (==, !=).

Try "Value[0]" or "Values[0][0]".

May 15th, 2011, 05:51 PM

Fat Tails

Try "Value[0]" or "Values[0][0]".

Works well! Many Thanks!

May 15th, 2011, 09:32 PM

inmax

Works well! Many Thanks!

Have you updated the BPSMA posted in post #4 to the one that now works ?

Lolu

May 16th, 2011, 12:29 PM

lolu

Have you updated the BPSMA posted in post #4 to the one that now works ?

Lolu

Right now, I updated the indicator in post #4.

Regards,
inmax

How to make SMA coloured histogram ?

Discussion in NinjaTrader

How to make SMA coloured histogram ?