What is wrong with this code?

August 18th, 2014, 09:49 AM

Howdy all,

I'm trying to create Connie Brown's Composite Indicator in MultiCharts using the TradeStation code provided by Brown. Everything compiles OK, but all the chart values display as zero.

I know next-to-nothing about EL or PL, and I haven't found the indicator code anywhere all ready to go in MultiCharts.

If someone can get this to work in PL, I can then upload it to the forum for others. If the code already exists for PL, then a link to that would be appreciated.

Here is Brown's description/code for the indicator, with some PL mods provided by others:

-Create two functions in EasyLanguage first. The first is a 9-period momentum study of RSI. This can be written as:
RSIDelta = MOMENTUM(RSI(CLOSE,14),9)

-Then a smoothed short period RSI is created,
RSIsma = AVERAGE(RSI(CLOSE,3),3)

-The indicator can then be created:
vars:rsidelta(0),rsisma(0);
Plot1(RSIdelta+RSIsma,"Plot1");
Plot2(average((plot1),13),"Plot2");
Plot3(average((plot1),33),"Plot3");

Regards,

DC

ABCTG · August 18th, 2014, 10:32 AM

DC,

writing the code like this will give you a result. However you might want to clean it up a bit:

Code

vars:rsidelta(0),rsisma(0);

RSIDelta = MOMENTUM(RSI(CLOSE,14),9);

RSIsma = AVERAGE(RSI(CLOSE,3),3);

Plot1(RSIdelta+RSIsma,"Plot1");
Plot2(average((plot1),13),"Plot2");
Plot3(average((plot1),33),"Plot3");

My guess is your code didn't include the calculations for RSIDelta and RSIsma.

Regards,
ABCTG

August 18th, 2014, 10:48 AM

ABCTG

DC,

writing the code like this will give you a result. However you might want to clean it up a bit:

Code

vars:rsidelta(0),rsisma(0);

RSIDelta = MOMENTUM(RSI(CLOSE,14),9);

RSIsma = AVERAGE(RSI(CLOSE,3),3);

Plot1(RSIdelta+RSIsma,"Plot1");
Plot2(average((plot1),13),"Plot2");
Plot3(average((plot1),33),"Plot3");

My guess is your code didn't include the calculations for RSIDelta and RSIsma.

Regards,
ABCTG

Hi ABCTG,

Thanks for pointing that out - it's all good now!

I didn't realize I had to include the calculations for RSIDelta and RSIsma in the indicator code itself instead of creating them in two separate functions as Brown had...

DC

ABCTG · August 18th, 2014, 10:57 AM

DC,

I suspect you didn't create them as functions properly then. As otherwise it should work the same in EL or PL.
In case RSIdelta and RSIsma are two functions without inputs the following code would work and give the same result as the one I posted.

Code

Plot1(RSIdelta+RSIsma,"Plot1");
Plot2(average((plot1),13),"Plot2");
Plot3(average((plot1),33),"Plot3");

It might be possible that by declaring two variables with the same name as the two functions you made the code not use the functions.

Regards,
ABCTG

dennisconn

Hi ABCTG,

Thanks for pointing that out - it's all good now!

I didn't realize I had to include the calculations for RSIDelta and RSIsma in the indicator code itself IN ADDITION to already creating them in two separate functions... seems unnecessarily redundant.

Is that an oddity particular to PL that doesn't exist in EL?

DC

What is wrong with this code?

Discussion in EasyLanguage Programming

What is wrong with this code?