bool switch... simple..

December 11th, 2012, 01:46 PM

Ohhh! Clever...

That was just the "long signal basic" though correct? Does that resolve the issue seen in that close up image for you?

December 11th, 2012, 01:49 PM

Thanks but in my case not clever so much as persevering :-/ I couldn't see the error until I could duplicate the problem--funny how the mind works.

December 11th, 2012, 01:53 PM

Indeed.

December 11th, 2012, 01:58 PM

toddma

That was just the "long signal basic" though correct? Does that resolve the issue seen in that close up image for you?

You're getting multiple intrabar orders at exits likely because

1. bar magnifier is on
2. entry conditions exist at the time (i.e., fast MA > slow MA); and
3. Your profit exit*** is causing the trade to close very quickly--you might want to confirm you have the symbol settings (scale, movement and bigpointvalue) configured properly.

***

Code

// Just a long target
if positionprofit > 4000 then begin
sell ("target") quantity Contracts next bar at market;
CloseTrade = False;
end;

In general (i.e., even with bar magnifier off and no profit exit) new orders will be generated when the last trade closes if entry conditions exist.

December 11th, 2012, 01:58 PM

Yes, depending on what the entry signal is perhaps you better can use
Cross Above or Cross Below with the MA's

Also all the CloseTrade switches is rather confusing make a condition
and check it rather then switching it on or off

condition1 = close <= keltnerchannellower(close,25,2.5)

if marketposition = 1 AND condition1 then
etc etc

bnichols

If you do not test for flat the line

Code

CloseTrade = False;

will be executed every time an entry signal is generated by the MA's whether or not a new position is opened. THIS IS WHAT IS CAUSING THE HAVOC.

Edited to add: not sure why it took so long to manifest itself on my system or why turning bar magnifier on finally triggered it.

December 11th, 2012, 03:07 PM

bnichols -
I have bar magnifier on, but it doesn't seem to be an issue with other scripts I use. I have that profit target turned off for simplicity and all of the exits that follow the entries are "CloseTrade" exits. So it must still have something to do with the CloseTrade code...
If you think about the order of events in the code the CloseTrade exit is last and the last thing in that block is to turn the CloseTrade variable to False. So how could the next bar after re-entering (which also has a CloseTrade = False in it) still execute the CloseTrade Exit further down the code (which requires CloseTrade = True)?

ehlaban -
I don't see how using conditions would replace using the bool variable we have- is that what you are suggesting? I agree it would be simpler and clearer but I don't think the same end goal can be achieved.. ? unless I am missing something?

December 12th, 2012, 06:05 AM

I now understand the logic about the CloseTrade better. It indeed is a switch.

A thing i noticed is that when exiting a trade next bar at market
it is possible that another buy is given in the same next bar due to the
IntrabarOrder etc etc. You could use sell this bar at close but this code works for me:

Code

[IntrabarOrderGeneration = True]

inputs: Num1(40), Num2(60), Num3(18), profitamount(4000);
variables: CloseTrade(false);



If marketposition = 0 then
begin
	CloseTrade = False;

	if Average(close, Num1) Cross Above Average(close, Num2) then 
	buy ("long") next bar at market;
end;

if marketposition = 1 AND CloseTrade = False then
begin
	if Close <= keltnerchannellower(Close, 25, 2.5) then CloseTrade = true;
end;


if marketposition = 1 AND CloseTrade = True then
begin
 	if Close > Average(Close, Num3) then sell ("CloseTrade") next bar at market;
end;


SetStopContract;
SetProfitTarget(profitamount);

December 12th, 2012, 06:55 PM

Hi Ehlaban - I think you've solved this puzzle! I haven't had a chance to take a close look yet, but initially all seems to be functioning as it "should" even with intrabarorder gen!
Great job.

Thanks for your help!

bool switch... simple..

Discussion in EasyLanguage Programming

bool switch... simple..